May2023 corrections #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up end VRI-BEM-WHR. Made small fixes to other functions, including addressing issue of NA vs blank data for character strings.
Yes! |
Thank you! |
nicgauthier
reviewed
Sep 18, 2023
| extract_large_polygons <- function (vri_bem) { | ||
|
|
||
| #find polygons ovre 3500 ha | ||
| large_polygons <- vri_bem %>% |
There was a problem hiding this comment.
Just a suggestion but R now has a pipe operator included in base R |> instead of %>%
nicgauthier
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some extra functions (in read_layers, as well as amend_large_polygons and clean_vri_bem_output). Fixed the NA/"" issue.
@Karine-Pigeon, @nicgauthier Could someone review this?