-
-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would you consider adding a SortCode for banking data? #77
Comments
Hi there @cmatskas , Thank you for your suggestion. I'm glad you like Bogus 😎. It should be pretty easy to extend Bogus to support ShortCodes. Also, I'd be happy to accept a PR for your feature so others benefit too. I'm not fimilar with UK ShortCodes but 1) since this is locale specific to the UK and 2) I don't think you would need Here is how to do that:
ExtensionsForUnitedKingdom.cs:
FinanceTest.cs:
Once your changes are published on NuGet, you'll add the new
and all UK related extension methods light up over Bogus' API. Please feel free to ping me at anytime if you need help with anything. Hope that helps! ⌚ 🌆 "I just can't wait... I just can't wait... for saturday night..." |
@bchavez this is freaking awesome! Probably the best response to an issue I've ever got. For this alone, I'll spend some time and raise the PR. Thanks again my friend and keep up the great work :) 👍 |
Hi @cmatskas , Good news, your feature request for UK banking Short Codes are now available in Bogus v19. Simply import the The Enjoy :) Thanks, |
How come they're named ShortCodes here? The OP even says SortCode? Great extension BTW, just a little confused as a consumer. |
Hi @Nosmadas, Thanks for your question. The official API is
My reference to ShortCodes (with an s) in this thread is in the plural form (as a group) and references the ability to generate more than one Is there something else in the United Kingdom that is also called "ShortCodes" that can cause confusion between ShortCode and ShortCodes? Thanks, 💨 🚶 "Bubbles of gas in my brain... Send me off balance, it's not enough" |
Hey @bchavez The API looks great. I was referring to this instead - https://en.wikipedia.org/wiki/Sort_code rather than plural vs singular. Sort vs Short. |
Ahhh, now I see. Well, I screwed up that one pretty badly didn't I? The dyslexia is real. I have no idea why I read "Sort" as "Short" (as in small). Lmao. 😃 My bad. I'll rename this API to Should be in a few hours, currently putting the final touches on some other new features. 👍 |
Although you've very well defined a BIC and an IBAN, I was wondering how easy it would be to get an option to add SortCode (6-digits) which are specific to the UK.
If not, is there an easy way to achieve this though the existing, built-in APIs?
Thanks for the great effort and tool btw
The text was updated successfully, but these errors were encountered: