Inconsistency between AND and OR ReqlExpr methods

[quentez]

At the moment, the signature for Or() on a ReqlExpr is:

Or(object exprA, params object[] exprs)

And for And():

And(params object[] exprs)

Not only would it be more consistent to have Or() behave like And(), it would also make it easier to build these kinds of expressions dynamically from a collection of items.

[bchavez]

Hi @quentez ,

Thanks for bringing up the issue, I appreciate it. You raise an interesting issue. As far as I can tell, I don't immediately see a reason the signatures for And and Or to be different. Although the Java driver has similar method signatures:

Java Driver: ReqlExpr.java

    public Or or(Object exprA, Object... exprs) {
      ....
    }
    public And and(Object... exprs) {
      ....
    }

At least for now, there isn't anything I can do until I can get another set of eyes to look at the method signatures in the Java source. I think this needs to be investigated further upstream in Java Driver since our C# AST is sourced from the Java Driver's metadata.

ping: @deontologician

PS. I was just made aware that Josh is currently on vacation. He wont be back until the end of next week.

[quentez]

Thanks for the quick fix :) !