-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do_ could be renamed to do #42
Comments
This would probably require the C# driver to re-implement some of the logic currently done in the Java driver's python code. That's where the mapping from reql terms to method names happens. I think RethinkDb.Driver uses only the output of that process, For reference, the mapping of keywords happens here: https://github.com/rethinkdb/rethinkdb/blob/next/drivers/java/metajava.py#L143 You could easily modify metajava.py to have an empty |
Echoing everything the masterful @deontologician said. Just a small addition: We do a tiny itsy-bitsy bit processing on top of The C# driver still needs the Java's Here's an example:
I think writing code to maintain special cases for Eventually, we'll be able to remove the internal Java API compatibility layer soon as (IIRC) rethinkdb/rethinkdb#5003 is done. Once rethinkdb/rethinkdb#5003 is done, I think we'll use a |
do_ method in java only has underscore because it conflicts with the keyword, right? With the capitalization C# does not have this probelm
The text was updated successfully, but these errors were encountered: