-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package lists dev dependencies as dependencies #561
Comments
These are used for formatting the output, and for describing input types for TypeScript users. |
I think you misunderstood me: I am not advocating to remove prettier or the type stubs. Those packages are absolutely valid, but should be moved from the package The way it currently is causes problems in other apps. |
@Radiergummi prettier is exposed to consuming code, since it is used as part of the output formatting process. Similarly, the |
Well. That doesn't help too much if I cannot install the package in the first place; maybe they could somehow be made a peer dependency? |
Your package appears to erroneously have some devDependencies in the dependencies array:
I'm pretty confident neither the
@types
stubs, nor prettier itself belong in the dependencies; I'm not sure about the rest, but they look legit.This is causing issues in downstream packages that depend on
json-schema-to-typescript
, where those packages are installed alongside application dependencies -- in my specific case, I'm using prettier 3, but TypeScript insists myConfig
interface has version 2.6, because it resolves the type to the one in@types/prettier
installed from this package:In conclusion: Could you move those dependencies to the devDependencies where they belong? That would be awesome. Thank you!
The text was updated successfully, but these errors were encountered: