Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Docs Review #2

Open
6 of 8 tasks
jliversi opened this issue Dec 6, 2019 · 0 comments
Open
6 of 8 tasks

Design Docs Review #2

jliversi opened this issue Dec 6, 2019 · 0 comments

Comments

@jliversi
Copy link
Collaborator

jliversi commented Dec 6, 2019

Hey Brandon, fantastic work on your design docs, just a few notes of things to fix:

MVP LIST

  • Heroku should be your first MVP (this will be finished by the end of Monday 12/9)

SCHEMA

Server

  • Names don't need to be unique

  • Add a column for the invite code. On real discord this refreshes daily, I'd recommend having one permenant one per server and then later refactoring this to change daily as a bonus.

  • I think it's worth having DMs be a seperate table, so you can leave this as is.

SAMPLE STATE

Users

  • Add an array of "adminedServerIds"

  • Discord has a lot of modals so you'll want to add a ui slice of state for modals.

BACKEND ROUTES

  • These are perfect. As mentioned above, I do recommend making DMs their own resource

FRONTEND ROUTES

  • Your frontend routes are mostly solid, but flesh out all of your components with their relevant subcomponents. For example, a ServerIndex likely has ServerIndexItem components. Your ChannelChat will have Message components, etc. Try to be as specific and details as possible as this will be your roadmap when building out the frontend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant