Config helper

[puschie286]

config helper implementation for #1071

Signed-off-by: Christoph Potas christoph286@googlemail.com

[lonnieezell]

Looks good. Please add docs and some tests for the class please, and then we are good to go.

[lonnieezell]

Please provide an example in the docs about using the config helper with a full namespace, and then I'll be happy to merge!

[jim-parry]

Something is broken in the travis-ci unit tests.
This PR actually did not pass the tests ... I get the following when I run it locally:

1. CodeIgniter\Config\ConfigTest::testCreateSingleInstance
   Failed asserting that null is an instance of class "Config\Email".

/pub7/htdocs/CodeIgniter4/tests/system/Config/ConfigTest.php:14

2. CodeIgniter\Config\ConfigTest::testCreateSharedInstance
   Failed asserting that false is true.

/pub7/htdocs/CodeIgniter4/tests/system/Config/ConfigTest.php:31

Looking at the travis-ci results, it shows an error and four failures, but then echos "Hello World" at the end of the row after 1403/2089 and then exits with "success" !?

[jim-parry]

ps - the error and two failures outside of ConfigTest show in other PRs, and were not caused by this PR.

[puschie286]

Hmm, the tests passed locally - it’s pretty weird, not sure what’s the different between our installation that can cause this.

[jim-parry]

Are you perchance running on WIndows locally?

[puschie286]

Yes

…

On Jun 28, 2018 at 8:20 PM, <BCIT Instructor ***@***.***)> wrote: Are you perchance running on WIndows locally? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (#1073 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/ACUQbMDiUospEslrUhx5gwMXsZ_MuoQeks5uBR5YgaJpZM4Unjng).

[jim-parry]

Oops. Config::get('email') will return a class on your system because WIndows is case-insensitive. Linux won't find it, hence the test fails.
Lines 10 & 28 in your test will not return a class on Linux.

[jim-parry]

Better practice is to test on Linux, eg inside Windows bash shell or inside a VM (eg VirtualBox), to avoid things that Windows will let slip through. I use Linux natively, and I think Lonnie uses VirtualBox + Vagrant on MacOSX.

[puschie286]

Oh, so i can’t handle lower case class names at all.
I will push the needed changes tomorrow.

[jim-parry]

The alternative is to UCfirst the class name that results, which should work on all platforms.

[puschie286]

hmm, the internet says no -> php is not case sensitive for classes SO

i guess the filenames are the problem, because we are loading them directly.

update : #1088

[jim-parry]

It is not a classname case sensitivity, it is a filename case sensitivity problem.
If you have a file AbCdEf.php, containing a PurpleDragon class definition, then you can load it as "abcdef.php" on Windows, but you need to use the correct filename case on Linux, or the source file will not be found.
Once loaded, you can then instantiate purpledragon or PURPLEdragon or whatever :-/
The example here is purposeful, to highlight the different issues.