Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix TypeError in MemcachedHandler::__construct() #1383

Merged
merged 2 commits into from
Oct 31, 2018
Merged

fix TypeError in MemcachedHandler::__construct() #1383

merged 2 commits into from
Oct 31, 2018

Conversation

ytetsuro
Copy link
Contributor

@ytetsuro ytetsuro commented Oct 29, 2018 •
edited

Description

fix #1204

port from RedisHandler

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@jim-parry
Copy link
Contributor

Broken unit tests...

  1. CodeIgniter\Cache\Handlers\MemcachedHandlerTest::testIncrement
    ErrorException: Undefined index: memcached
    /home/travis/build/bcit-ci/CodeIgniter4/system/Cache/Handlers/MemcachedHandler.php:78
    /home/travis/build/bcit-ci/CodeIgniter4/tests/system/Cache/Handlers/MemcachedHandlerTest.php:77
  2. CodeIgniter\Cache\Handlers\MemcachedHandlerTest::testDecrement
    ErrorException: Undefined index: memcached
    /home/travis/build/bcit-ci/CodeIgniter4/system/Cache/Handlers/MemcachedHandler.php:78
    /home/travis/build/bcit-ci/CodeIgniter4/tests/system/Cache/Handlers/MemcachedHandlerTest.php:96

@jim-parry jim-parry changed the title 【#1204】fix TypeError in MemcachedHandler::__construct() fix TypeError in MemcachedHandler::__construct() Oct 29, 2018
@ytetsuro
Copy link
Contributor Author

Broken unit tests...

Oh... I'm Sorry...
that is fixed now.

@lonnieezell lonnieezell merged commit feed450 into codeigniter4:develop Oct 31, 2018
@ytetsuro
Copy link
Contributor Author

Thanks merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError in MemcachedHandler::__construct()
3 participants
@ytetsuro @jim-parry @lonnieezell