Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed not to output "Hello" at test execution. #1390

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Fixed not to output "Hello" at test execution. #1390

merged 1 commit into from
Oct 30, 2018

Conversation

ytetsuro
Copy link
Contributor

@ytetsuro ytetsuro commented Oct 30, 2018 •
edited

Description

Fixed not to output Hello at test execution.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ytetsuro
fix: remove output Hello when run unit-test.
b81be83 
Signed-off-by: ytetsuro <phper.0o0@gmail.com>
@jim-parry jim-parry changed the title 【Unsolicited PR】Fixed not to output "Hello" at test execution. Fixed not to output "Hello" at test execution. Oct 30, 2018
@jim-parry jim-parry merged commit 2c87e29 into codeigniter4:develop Oct 30, 2018
@ytetsuro
Copy link
Contributor Author

Thanks merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ytetsuro @jim-parry