Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propose form helper function usage in sample view form and documentation #1409

Closed

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Nov 4, 2018

There is sample form view at application/Views/form.php, I think it is better to show of the usage of 'form' helper. Also, in documentation, we already open the form with form_open(), and rest of code sample was using normal html, the form helper usage is for consistency for its usage to the rest.

Checklist:

  • Securely signed commits
  • User guide updated

@jim-parry
Copy link
Contributor

application/Views/form.php looks like cruft accidentally introduced as part of a non-PR commit in Sept 2016. I don't think it belongs at all. @lonnieezell ?

@jim-parry jim-parry added the waiting for info Issues or pull requests that need further clarification from the author label Nov 8, 2018
@lonnieezell
Copy link
Member

Yes, that looks like it should go away. Also - I'd rather not use any more of the form library in that example than we already do. It just adds another thing to learn for someone already trying to get to grips with the framework. If anything, I'd rather see the form_open tag removed and a normal <form> tag in its place, followed by a csrf_field() called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for info Issues or pull requests that need further clarification from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants