Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spark serve not working from commit 2d0b325 #1410

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

samsonasik
Copy link
Member

In previous latest commit 2d0b325 , the HTTPVerb property of RouteCollection changed by call Services::request()->getMethod() by @lonnieezell that make command:

php spark serve

Got output:

ERROR: 404
Controller or its method is not found: App\Controllers\Ciserve::index

Checklist:

  • Securely signed commits

ping @lonnieezell

@lonnieezell
Copy link
Member

While there are definitely some problems with my latest commit that I'll fix tonight, the solution isn't just to revert. There were probably reasons why I changed that. :)

I'll revert for now since I know there's at least one other issue I didn't notice until after. But expect it to change back to something similar tonight. I hadn't thought of it not working from here, though, so I'll keep an eye out for that.

@lonnieezell lonnieezell merged commit 9d6f516 into codeigniter4:develop Nov 5, 2018
@samsonasik samsonasik deleted the fix-spark-serve branch November 5, 2018 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants