Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes extension in CLI file #633

Closed
wants to merge 2 commits into from
Closed

removes extension in CLI file #633

wants to merge 2 commits into from

Conversation

thanhtaivtt
Copy link

No description provided.

@jim-parry
Copy link
Contributor

not to be too picky, but we expect commits to be GPG-signed :)

@lonnieezell
Copy link
Member

Can you confirm whether this causes any issues under Windows? That's what I hadn't taken the time to fully investigate, yet.

@thanhtaivtt
Copy link
Author

It can run in any operator. Like laravel artisan

@lonnieezell
Copy link
Member

IIRC Windows cmd line doesn't support !# commands, and the path would be different even if did. And I don't think there's any way, just out of the box, to convert a file with no extension into a executable. Granted, it's been a decade since I used Windows, so memory may be foggy. And I know that the Creators Update for Win10 brought full bash support, but that doesn't help anyone pre-update.

A quick search of the issue and here's what I've found:

And a few others. So, basically, Windows users will have to use php ci or whatever, as will any Mac users who have a PHP in a different path that the !# states, anyway.

So, I guess I don't have any objections to changing ci and `serve, but redirect should keep the extension since it's not a user-callable script.

We do need to update the docs, though. As a starter, this page needs updating to remove the extension from the examples, and provide a note for Windows users that they need to ensure PHP is callable and to add the PATH to their environment, etc. The local server page would need to be updated, and the rest of the docs would need to be scanned for any place that used a CLI example.

EDIT: There is a linux command ci that this could come into conflict with, so maybe hold off until we determine how to handle that.

@thanhtaivtt
Copy link
Author

thanhtaivtt commented Jul 29, 2017

Thank you for me develop more knowledge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants