New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Active Record Join Multiple conditions #7
Comments
I have the same issue using postgre driver... please fix this one this a major bug ! |
Tim, thanks for addressing this issue. I think it might need some tweaking, or I am not implementing correctly. Using the above query as an example.
will create a query string like
Protecting 0 causes a MySQL error. I'm not even sure if this type of case should be automatically handled in the join method. I would of course like it to be, but it might break some other case. For now, I'm just protecting identifiers long hand in the active record query itself, kind of like this post. |
This is being handled in #759. |
If there is a JOIN with multiple conditions it does not escape everything
For example:
{{{
!php
->join('tasks', 'projects.id = tasks.project_id AND tasks.deleted=0', 'left')
}}}
does not add the table prefix to the condition tasks.deleted=0
The text was updated successfully, but these errors were encountered: