-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Colab support #13
Comments
Hey Filippo! Also tagging @okhat as it's something we've been discussing and that we want to fix. The issue seems to be down to us using multiprocessing/forking, which hangs forever in certain environments. The fix, or workaround, would be to simply not fork when there is a single GPU, which would cover most of the situations where the hanging is noticeable (assuming that it's very uncommon to train on multi-GPU in colab/other non-jupyter notebooks envs). I think upstreaming it to the main ColBERT repo would be ideal: https://github.com/stanford-futuredata/ColBERT . You can check out any of the main files (Indexer.py, Trainer.py, etc...) to get an idea of how the process pool is handled at the moment. |
Would you have a sample notebook I could use to test the issue? Not that I am an expert in this ... but I could have a look at it at least. |
The example training notebook is a good one! If you run it on Colab, it will hang once you get to the |
A quick update after an initial run of the example training notebook:
The notebook does NOT hang while executing the cell with
Looking inside the
This seems to be correct, right? |
@bclavie let me know if I am missing anything ... it seems to be working fine for me with a T4 GPU on Google Colab. |
Hey @filippo82, this is strange, I'm still getting hangups 🤔. I will be trying to have a deeper look at some point to figure out exactly what's causing the hangups! #> Starting...
#> Joined... This output is also quite strange, as I'd expect it to get the normal main process prints (i.e. the training config and the loss at each training step) Out of curiosity, does Indexing run fine on your end too? |
Hi @bclavie, if you see the |
Oh I didn't realise it was a truncated output you were sharing, I thought you meant that was the whole output! Colab still hangs when I try it, and it still hangs on Windows (though less important a problem), so there's something fishy going on 🤔 I'll try and dig to figure it out |
Hi there,
do you have any ideas/clues for the issue with Google Colab? If yes, I could look into this?
The text was updated successfully, but these errors were encountered: