Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard more bad source map positions #255

Merged
merged 1 commit into from May 11, 2016
Merged

Discard more bad source map positions #255

merged 1 commit into from May 11, 2016

Conversation

novemberborn
Copy link
Contributor

Spotted positions like these in coverage output when debugging #239:

            "1": {
                "start": {
                    "line": 1,
                    "column": 0
                },
                "end": {
                    "line": null,
                    "column": -1
                }
            },

This PR adds a guard against badly adjusted end positions, causing those locations to drop out of the report.

@novemberborn
discard more bad source map positions
6c4f2f9 
Extract the verification logic into a helper function. Add a guard against badly
adjusted end positions.
@bcoe
Copy link
Member

bcoe commented May 11, 2016

@novemberborn awesome, good work.

@bcoe bcoe merged commit 0838a0e into master May 11, 2016
@novemberborn novemberborn deleted the discard-bad-map-positions branch May 13, 2016 11:18
@bcoe bcoe mentioned this pull request May 14, 2016
Closed
sdd added a commit to sdd/istanbul-lib-source-maps that referenced this pull request Aug 30, 2016
@sdd
fix: discard more bad source map positions
7b649ed 
Restore code that was introduced in nyc 6.5.0 to handle bad source map locations. This fix was originally introduced into nyc's lib/source-map-cache.js, but when nyc transitioned to using istanbul-lib-source-maps this fix went astray.

see original PR: istanbuljs/nyc#255
@sdd sdd mentioned this pull request Aug 30, 2016
Merged
bcoe pushed a commit to istanbuljs-archived-repos/istanbul-lib-source-maps that referenced this pull request Aug 31, 2016
@sdd @bcoe
fix: discard more bad source map positions (#3)
ed7b27f 
Restore code that was introduced in nyc 6.5.0 to handle bad source map locations. This fix was originally introduced into nyc's lib/source-map-cache.js, but when nyc transitioned to using istanbul-lib-source-maps this fix went astray.

see original PR: istanbuljs/nyc#255
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@novemberborn @bcoe