Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "instrument" option as alternative to specifying noop instrumenter #278

Merged
merged 2 commits into from Jun 14, 2016

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Jun 14, 2016

it felt a little weird providing a noop instrumenter directly in __coverage__, this pull introduces the instrument flag instead -- making it possible to setup __coverage__ with the following config:

 "nyc": {
    "include": [
      "index.js"
    ],
    "require": [
      "babel-register"
    ],
    "reporter": [
      "lcov",
      "text"
    ],
    "sourceMap": false,
    "instrument": false
  }

which feels cleaner.

@bcoe
Copy link
Member Author

bcoe commented Jun 14, 2016

@dtinth added the --instrument flag which, in my opinion, makes configuring __coverage__ feel less weird.

@bcoe bcoe merged commit ea028b9 into master Jun 14, 2016
@bcoe bcoe deleted the instrument branch June 14, 2016 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant