Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get tests passing on Windows #107

Merged
merged 10 commits into from Dec 20, 2015
Merged

get tests passing on Windows #107

merged 10 commits into from Dec 20, 2015

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Dec 20, 2015

This wasn't as much work as I'd feared, fixes #81 \o/

screen shot 2015-12-19 at 10 14 35 pm

Here's a break down of the changes I've made:

  • I've added the appveyor.yml that @sindresorhus recommended.
  • I switched to using rimraf for deleting left over test data, since it's cross-platform.
  • windows doesn't (or at least signal-exit on Windows) doesn't support process.kill(), I've disabled the two tests that require process.kill using the is-windows module.
    • I've also made the spawn tests not rely on scripts that call process.kill.
  • I was running into issues with path.sep being \ on Windows and / on *nix.
    • nyc and Istanbul have paths that are all over the place on Windows (sometimes using one separator, sometimes another).
    • rather than try to unravel this mess (since it doesn't break anything but tests) I've written the helper module any-path: https://www.npmjs.com/package/any-path

This work would not have been possible if it wasn't for the hard work of @jamestalmage @novemberborn , refactoring and fixing up tests.

Thank you everyone for all the hard work on this module recently \o/

Reviewers: @jamestalmage @novemberborn

@novemberborn
Copy link
Contributor

Nice! :shipit:

@sindresorhus
Copy link
Member

:shipit:

bcoe added a commit that referenced this pull request Dec 20, 2015
get tests passing on Windows
@bcoe bcoe merged commit 87dd84a into master Dec 20, 2015
@bcoe bcoe deleted the windows branch December 20, 2015 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows support
3 participants