load in instrumenter configuration from .istanbul.yml #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
added a commit
that referenced
this pull request
May 23, 2015
load in instrumenter configuration from .istanbul.yml
|
👍 Many thanks for following this up, and fixing the things I missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome work @shackpank. I added a few tests, but otherwise things seemed to work great. a couple notes:
nycrelies on the global coverage variable being__coverage__I've made this value hardcoded (in subprocesses I've seen some issues surrounding accessingprocess.globals, so I think it's good to push people towards__coverage__).this.cwddirectory variable, so that we'll keep loading the appropriate.istanbul.ymlascwdis changed in tests.