Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify action example #182

Open
bcomnes opened this issue May 1, 2024 · 1 comment
Open

Simplify action example #182

bcomnes opened this issue May 1, 2024 · 1 comment

Comments

@bcomnes
Copy link
Owner

bcomnes commented May 1, 2024

I thought it would be helpful to people to see an example of a build step in a website but it really just confuses many people.

Sites that build with npm deps should just use the upstream CLI, and action users should just see an example where a folder in a repo gets deployed, with no other steps to confuse the process.

@Len42
Copy link
Contributor

Len42 commented May 19, 2024

I never used Actions until an hour ago, and I was a bit confused by this. In particular, I wondered if the line "uses: actions/setup-node@v3" would be required to run the deploy action (but apparently not).

Maybe just comment out the build step so it still serves as an example but won't mess things up when someone just copies the yml file verbatim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants