Image->render() signature

[xfra35]

On the docs, we have the following signature:

$img->render( [ string $imageformat = 'png' [, int $quality [, int $filters ]]] );

But in reality, the render() method takes the same signature as imagejpeg and imagepng, which means the second argument should either be NULL or a string or a stream.

So what do you think guys? Should we fix the docs or fix render()?

Fixing the docs is easy but on another hand, that extra second argument is useless as it should always be set to NULL since render() is meant for output rendering.

The same reflexion applies to dump().

[ikkez]

Well as it's not really meant to use that parameter, I think we should patch render() and dump() accordingly.

[KOTRET]

atm Image->render is just a wrapper for calling image(jpg|png).
According to the docs it should just output the image to the client, so the method needs a patch to include a null-param.
Sidenote: looks like imagejpg does not support the filters argument.

[xfra35]

Ok thanks guys. Fixed then.