LDAP changes to for AD flexibility #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KOTRET
reviewed
Oct 16, 2017
auth.php
Outdated
| user_error(self::E_LDAP,E_USER_ERROR); | ||
| $port=intval($this->args['port']?:389) | ||
| $this->args['filter']=$this->args['filter']?:"uid=".$id; | ||
| $filter=$this->args['filter']=$this->args['filter']?:"uid=".$id; |
There was a problem hiding this comment.
2nd assignment repeated from one line above
There was a problem hiding this comment.
Damn - missed that. :(
119 is the line to go.
|
Looks fine 👍 Can someone please verify/test this change once more?!.. got no LDAP instance here atm. |
|
It works on the project I am using it currently for, but to play it safe, I can fire up a new LDAP server after work, and test it against that, if that's acceptable. Is there a test/design policy/standard that I should be following? |
|
The test cases are in the fatfree/dev branch. The problem is, that there are no LDAP tests (or I found none). I found only a few tests for Auth. |
|
there is missing semicol(;) at row 118 at lib/auth.php |
ikkez
added a commit
that referenced
this pull request
Oct 27, 2017
|
fixed. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned (and similar to PR1068 on bcosca/fatfree), changes made to make the LDAP auth work against and Active Directory environment ,with a few changes to keep it backwardly compatible to original code.