Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unison fails to build with ocaml 4.03.0 #12

Closed
fjaell opened this issue Apr 26, 2016 · 9 comments
Closed

unison fails to build with ocaml 4.03.0 #12

fjaell opened this issue Apr 26, 2016 · 9 comments

Comments

@fjaell
Copy link

fjaell commented Apr 26, 2016

make -j1 UISTYLE=text THREADS=true NATIVE=true unison unison-fsmonitor
...
ocamlopt -g -I lwt -I ubase -I system -I fsmonitor -I fsmonitor/linux -I fsmonitor/windows -I system/generic -I lwt/generic -c /tmp/unison/src/unison-2.48.3/system.ml
File "/tmp/unison/src/unison-2.48.3/system.ml", line 1:
Error: The implementation /tmp/unison/src/unison-2.48.3/system.ml
does not match the interface system.cmi:
Values do not match:
val symlink : ?to_dir:bool -> string -> string -> unit
is not included in
val symlink : string -> fspath -> unit
Makefile.OCaml:434: recipe for target 'system.cmx' failed
make: *** [system.cmx] Error 2

Same with unison 2.49.543. Both unison version build just fine with ocaml 4.02.x

@0-wiz-0
Copy link

0-wiz-0 commented May 6, 2016

I see the same. Is there a patch available?

@jaapb
Copy link
Contributor

jaapb commented May 6, 2016

The two attached patches solve the problem (at least, it compiles again...)
patch1.txt
patch2.txt

@bcpierce00
Copy link
Owner

Ouch. The patched version does indeed compile under 4.03 (thanks!), but it does not compile under 4.02! Wonder if there's any way we can have both...

@bcpierce00
Copy link
Owner

OK, I found a different way to patch it that also compiles under 4.02. Whew. Closing this pull request -- thanks for the help!

@brianthelion
Copy link

@bcpierce00 What was the solution for ocaml 4.02? I'm struggling here.

@bcpierce00
Copy link
Owner

Unison 2.48.4 should compile with 4.02 (and 4.03).

@bcpierce00
Copy link
Owner

(available on the Unison download page)

@brianthelion
Copy link

brianthelion commented Jun 10, 2016

@bcpierce00 Thanks! But not the Github master?

@bcpierce00
Copy link
Owner

The github master also compiles under both 4.02 and 4.02, but it's now at version 2.50, so it won't interoperate with 2.48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants