Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-only package #793

Closed
liyishuai opened this issue Sep 13, 2022 · 9 comments
Closed

CLI-only package #793

liyishuai opened this issue Sep 13, 2022 · 9 comments
Labels
feedback Information has been requested; may be closed in 30 days if not provided.

Comments

@liyishuai
Copy link
Contributor

The current Unison package requires lablgtk, making it incompatible with some Linux distributions per coq/opam#2303 (comment). Consider releasing a CLI-only package.

#671 should fix this.

@palmskog
Copy link

To be more precise, I think the problem is with lablgtk2 in Debian Bullseye - we have the following comment in our CI config:

apt-get install libgtksourceview2.0-dev -y || true # gone with Debian bullseye

However, lablgtk3 is what CoqIDE uses, so this should be supported across both lots of Linuxes and Windows and Mac.

@gdt gdt added the feedback Information has been requested; may be closed in 30 days if not provided. label Sep 13, 2022
@gdt
Copy link
Collaborator

gdt commented Sep 13, 2022

Could you edit this to be clearer? Unison is source, not binary packages, and I'm guessing you mean the opam/dune files that are checked in.

And, unison has switched to gtk3, so I'm not sure this makes sense against the tip of master.

@palmskog
Copy link

The latest release of unison on opam (2.52.0) requires lablgtk2, which is (at least from what I know) not supported in some recent Linux distributions. Hence, the lablgtk2 dependency can be a problem in packaging of projects like that by @liyishuai that depend on unison. If there was a released version of unison with lablgtk3 support (and marked thus in the official opam package), he could add his packages that depend on unison more easily. But the best solution would be if some CLI-only unison package (no dependency on lablgtk at all) was made available via opam.

@gdt
Copy link
Collaborator

gdt commented Sep 13, 2022

The latest release of unison is 2.52.1, so not sure what's up. But packaging systems are there own thing, and what the opam project does is not really in scope here, just as how pkgsrc, debian, RH, etc. handle unison is their issue.

That said, we are heading to 2.53.0 fairly soon. Testing of that is always appreciated.

@palmskog
Copy link

The packages available via opam directly (opam install unison) are those here, presumably maintained by volunteers: https://github.com/ocaml/opam-repository/tree/master/packages/unison

However, the issue is really unrelated to what exactly is available there, since to even have the possibility of building unison without lablgtk, the source code must have support for this, e.g., via the Dune build system. I presume #671 is a step towards this.

@gdt
Copy link
Collaborator

gdt commented Oct 9, 2022

I still don't entirely follow this. pkgsrc builds unison without a gui. So if it's a feature request to change the dune build files that are in the unison source tree, please either edit or open a new PR and say that clearly. Requests about files in an opam repo should be addressed to them. (From my point of view, dune is something some people use, and is not the primary build system.)

@gdt
Copy link
Collaborator

gdt commented Nov 15, 2022

I ran 'dune build -p unison' and got a CLI-only unison executable. However I see your point that the package file says it needs lablgtk3, even though it actually doesn't. Is that what you mean?

@gdt
Copy link
Collaborator

gdt commented Nov 15, 2022

Please see https://lists.seas.upenn.edu/pipermail/unison-hackers/2022-November/002061.html and followup on the list.

@gdt
Copy link
Collaborator

gdt commented Dec 2, 2022

I have restated the issue (in a way that future me will understand) in #842.

@gdt gdt closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback Information has been requested; may be closed in 30 days if not provided.
Projects
None yet
Development

No branches or pull requests

3 participants