Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the salt logic working? #120

Open
andrelip opened this issue Sep 22, 2015 · 4 comments
Open

Is the salt logic working? #120

andrelip opened this issue Sep 22, 2015 · 4 comments

Comments

@andrelip
Copy link

I'm using Comeonin.Bcrypt in an Elixir app. I can compare hashes with salts generated by the bcrypt-ruby but bcrypt-ruby cant compare with those that was generated by Comeonin.Bcrypt.

Example:
"abcabc12345" => "$2b$10$li1IT3V0dEi4czS74rGL/.rObZhj6k5wAMtzWZVKZxgxVyKeXAMGC"
Only works with the Elixir lib.

If I use a salt generated by bcrypt-ruby everything works. What lib is wrong?

@tjschuck
Copy link
Collaborator

The answer to "is bcrypt-ruby working?" is almost certainly "yes", or else there'd be a lot more issues being filed :) Please share your specific Ruby code of what you're trying to do so we can see if we can help.

@yoogeeks
Copy link

yoogeeks commented Sep 8, 2016

Apparently bcrypt-rubysupports only $2a$ prefix. Open PRs for $2b$ and $2y$ hash versions : https://github.com/codahale/bcrypt-ruby/issues/80, https://github.com/codahale/bcrypt-ruby/pull/91

@jeffdeville
Copy link

@tjschuck Can someone approve the PR's referenced by @yoogeeks? To the degree that bcrypt should be compatible with the current standards (2b, as I understand it, was released in 2014), it's definitely broken. If you're using it by itself, the problem won't be manifested. But if you're trying to interoperate, it's a problem. I fixed the same elixir compatibility issue by referencing glittershark's PR.

@duane
Copy link

duane commented Jan 5, 2017

@tjschuck Is there any hope to get $2b$ working? It's been out since 2014; the pull to upgrade the backend has been open since 2013(!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants