Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cost for tests #180

Open
Jefferson-Faseler opened this issue Aug 31, 2018 · 2 comments
Open

Remove cost for tests #180

Jefferson-Faseler opened this issue Aug 31, 2018 · 2 comments

Comments

@Jefferson-Faseler
Copy link

Hi, thank you for working hard to bring BCrypt to Ruby! I apologize if this is not the appropriate place for suggestions. However, is there any way to turn off the hashing so that the cost is truly zero? This is not meant for production of course, but for spec performance improvements. I understand the algorithm has a minimum, but is there the possibility of a return here ?

Thanks in advance!

@jensljungblad
Copy link

Wondering the same thing!

@joshbuker
Copy link
Contributor

Disabling the cost entirely defeats the point of even running the test in the first place, imo. I would recommend setting the cost in your test suite to be the current minimum (4) instead, which has the benefit of increasing spec speeds without the risk or potential complications of removing the cost entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants