Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress Merge: Don't rebuild unchanged mods #247

Open
MattMills opened this issue May 1, 2021 · 2 comments
Open

Compress Merge: Don't rebuild unchanged mods #247

MattMills opened this issue May 1, 2021 · 2 comments
Assignees
Labels
feature New feature or request
Milestone

Comments

@MattMills
Copy link

Is your feature request related to a problem? Please describe.
Excess time spent re-merging when changing/fixing mods.

Describe the solution you'd like
I would really love it if the merge -> compress feature didn't recompress mods that didn't need to be, perhaps by comparing mtime on the zip files with the mtime on the source mod folder? Alternatively some kind of combined hash of all files stored in a zip metadata file?

Describe alternatives you've considered
Don't think this applies, maybe I've missed something

Additional context
Nerp.

@MattMills MattMills added the feature New feature or request label May 1, 2021
@bcssov
Copy link
Owner

bcssov commented May 1, 2021

It's intentionally rebuilding mods as it's easier to rebuild than to store a hash of every file and check whether a mod needs to be re-merged. I'm looking for simplicity and maintainability not complexity in this case. In the end this is a process that is done perhaps once or twice not daily.

@MattMills
Copy link
Author

I've been re-compressing a lot lately with a few mistakes and trying to get mod updates in... /shrug up to you I just thought it'd be nice to recompress 1 mod in 15 seconds than the ~10-15 min it has been taking.

@bcssov bcssov added this to the vNext milestone May 31, 2021
@bcssov bcssov self-assigned this May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants