Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize SpecModel predictions #194

Open
bd-j opened this issue Nov 2, 2020 · 1 comment
Open

Optimize SpecModel predictions #194

bd-j opened this issue Nov 2, 2020 · 1 comment

Comments

@bd-j
Copy link
Owner

bd-j commented Nov 2, 2020

There are a number of potential inefficiencies in SpecModel.predict(), including multiple calls to functions that might not be cheap, reading emline_info from disk every call, and linear algebra operations on sparse matrices.

Also, add a public method to return emission line luminosities.

@bd-j
Copy link
Owner Author

bd-j commented Nov 4, 2021

Some of this was fixed by #219 (e.g. the emline_info caching) but there are still some linear algebra operations that might be made more robust or faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant