Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tostring of response body corrupts download of binary files #118

Closed
mattimatti opened this issue Oct 2, 2014 · 3 comments

Comments

@mattimatti
Copy link

commented Oct 2, 2014

Maybe not purpose of the library itself to download binary files but on line 250:

response.body = response.body.toString();

corrupts download of binary files

Ciao!
:m

@ghost ghost added the Feature label Oct 21, 2014
@ghost

This comment has been minimized.

Copy link

commented Nov 8, 2014

Same as #9 (comment)

I'll add this to the roadmap

@ghost ghost added the Bug label Nov 8, 2014
@ghost

This comment has been minimized.

Copy link

commented Nov 8, 2014

Same field as #53

@mike442144

This comment has been minimized.

Copy link
Collaborator

commented Dec 6, 2016

Just set encoding=null, so that crawler won't try to convert to string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.