Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressure Pipes drop stats from RCL liquid? #91

Closed
McJty opened this issue Dec 30, 2016 · 3 comments
Closed

Pressure Pipes drop stats from RCL liquid? #91

McJty opened this issue Dec 30, 2016 · 3 comments

Comments

@McJty
Copy link

McJty commented Dec 30, 2016

I have seen people comment about this but apparently your pipes drop stats from the RCL liquid that my mod has. What is special about this liquid is that it keeps stats in the FluidStack (NBT data). It seems that your mod (while transfering that liquid) doesn't preserve that?
@bdew
Copy link
Collaborator

bdew commented Dec 30, 2016

I don't intentionally drop the nbt tag anywhere (that i remember), but there might be bugs. I don't think i've seen any fluid with NBT data before...

I'll look into it later today.

bdew added a commit that referenced this issue Dec 31, 2016
@bdew
Fixed losing NBT data from fluids (#91)
a629668
@bdew
Copy link
Collaborator

bdew commented Dec 31, 2016

There were a few places where i was making new fluidstacks (without copying the NBT tag) when distributing fluids, Should be fixed now.

@McJty
Copy link
Author

McJty commented Jan 1, 2017

Thanks!

@McJty McJty closed this as completed Jan 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdew @McJty