Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding subtitle parameter to BookInfo #12

Closed
niklasenberg opened this issue Apr 29, 2022 · 0 comments · Fixed by #13
Closed

Adding subtitle parameter to BookInfo #12

niklasenberg opened this issue Apr 29, 2022 · 0 comments · Fixed by #13
Labels
enhancement New feature or request

Comments

@niklasenberg
Copy link
Contributor

niklasenberg commented Apr 29, 2022 •
edited

Hi! We are using books_finder for our school project and noticed some book titles are split between the 'title' and 'subtitle' parameter that is retrieved in the .json from Google's API. We'd really like to use both to get the full title's of some of our books. I updated the BookInfo class and wrote a test for it, see #13
@niklasenberg niklasenberg mentioned this issue Apr 29, 2022
Merged
@bdlukaa bdlukaa added the enhancement New feature or request label Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BookInfo.subtitle + test
2 participants
@bdlukaa @niklasenberg