Sometimes publishedDate is only a year #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawPublishedDate for own formatting
bdlukaa
reviewed
Mar 23, 2021
|
I have also add some tests and industryIdentifier to get ISBN and ISSN Numbers. Sry that now everything comes in a PR. I should have worked with branches. :-( |
|
LGTM! |
|
Published you pull request in version 4.0.0. Thanks for your contribution. If you want to join my discord server, you're welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I searched for Unorthodox, I noticed that there are some works where only the year is given. Then there was an array IndexOutOfBounds. I tried to solve it as simple as possible. Goes certainly still more elegantly.
BR Tim