Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

startLoop should be set to false on Linux #6

Closed
Yesterday17 opened this issue Dec 4, 2021 · 2 comments · Fixed by #7
Closed

startLoop should be set to false on Linux #6

Yesterday17 opened this issue Dec 4, 2021 · 2 comments · Fixed by #7

Comments

@Yesterday17
Copy link
Contributor

When calling constructor of Player:

just_audio_libwinmedia/lib/src/just_audio_libwinmedia_real.dart

Line 50 in 21b4315

: player = Player(id: _id),

startLoop: !Platform.isLinux must be add as the comment of libwinmedia suggests:
https://github.com/harmonoid/libwinmedia/blob/71a7f157a0d3ed9a6394e73de7585a7c9a3525fa/flutter/lib/src/player.dart#L147
@Yesterday17 Yesterday17 mentioned this issue Dec 4, 2021
Merged
@bdlukaa
Copy link
Owner

bdlukaa commented Dec 4, 2021

Why?

@bdlukaa bdlukaa closed this as completed in #7 Dec 4, 2021
@Yesterday17
Copy link
Contributor Author

startLoop on Linux calls gtk_main, which is unnecessary for audio playback.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make load not block ProjectAnni/just_audio_libwinmedia
2 participants
@Yesterday17 @bdlukaa