-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customization isn't applied: weights filter doesn't work; ligations variant "javascript" gets ignored #1340
Comments
Can you try building this without using Docker? |
You’ve built Iosevka Custom, but use Iosevka in your config. |
I have try to build, not use docker, using the config and the result is correct. Only produce regular and semibold weight with italic and oblique variants. |
Ok guys, let me try one more time, from scratch. |
So I rebuilt the fonts and tried to use them in VSCode. This time I used a config like:
and it generated these files in the
Then I copied them into
But after that, IosevkaSlab is still not available in VSCode. See the video: |
@OnkelTem The files produced look correct (you didn't override widths so you will have 12 files produced). As for Code, maybe... you need to restart Code to let it "see" newly installed fonts? |
@be5invis, and you're right! vscode just needed to be restarted! Now it works with the added "IosevkaSlab" font. But you know, what I don't get, is that in my previous attempts I used the default font family name "Iosevka Custom". But this is how they are displayed with
As you see, there is no the "Custom" word in the font names. VSCode also "confirms" this: setting Ideas? P.S. I plan to write an article on configuring and using the font afterwards. |
Using this config shoud produce file with name iosevka-custom-* in
IMO, don't use "Custom", use something unique to make debugging easier. |
For some reason your docker image stopped working on my machine. While I can run other images, e.g. https://hub.docker.com/_/hello-world :
I cannot run the font builder anymore:
|
Ok, it becomes really weird. I'm totally confused. |
I concluded that if it's not the docker/image issue, than it's a problem of what the container is actually doing. So it's now a matter of another ticket, about proper error messaging. |
Sorry for this thread becomes a little messy. |
The build process seems to be screwed up. I used docker thing. Are you @jamapy also using docker? I tried to fetch the repo itself but for several hours it hasn't been downloaded (32Gb). Sorry I'm giving up. |
Sorry @OnkelTem I don't use docker. Just plain git clone directory in my arch linux laptop. Dependency only need to install npm and ttfautohint. You don't need to download entire repo to build. This is how I git clone iosevka to build: to build, create check To update Iosevka, just |
Thanks @jamapy, I'll try! It's worth adding into the README I believe. |
Ok folks, I've finally found the reason. As for the npm. After I had it fetched as @jamapy suggested, I could build my font immediately. Thanks. |
Feel free to submit PRs to update docs (and please target it to |
Sure @be5invis! Are site sources here in the repo? I'd like to make a minor correction into the |
@OnkelTem Site source is not there. Maybe I should add it later... |
@OnkelTem Can you please confirm, are there any errors with the docker image we should look out for, or was it just on your end? |
@ToxicSmurf At my side customization worked correctly. It looks like it is related with that Docker image. |
@ToxicSmurf not really errors of the docker image, but it was masking error I had. Specifically, if you passed an option like |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
I use the following config:
and docker for building my font:
But on the output I get all weights including thin and extrabold.
Another problem is that triple
=
(===
) results to two lines while according to the "javascript" variants template there should be three.Also I noticed that two long lines in long = have gaps inside. They are distinguishable on the screenshot.
The third problem is that
Width Option
isn't applied as well. Changing it toStandard/Extended
doesn't make any difference.My VSCode font config:
P.S. Why there goes an indent in the
[buildPlans.iosevka-custom.ligations]
line here?The text was updated successfully, but these errors were encountered: