Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Iosevka requires specific version of node.js? #46

Closed
van-de-bugger opened this issue Dec 29, 2015 · 2 comments
Closed

Does Iosevka requires specific version of node.js? #46

van-de-bugger opened this issue Dec 29, 2015 · 2 comments

Comments

@van-de-bugger
Copy link

Sorry, I have no experience with node.js. I am trying to build Iosevka, make fails with error:

$ make
make[1]: Entering directory '/home/vdb/tmp/Iosevka'
    Start build font Iosevka Thin 1.5.5 (Elvirel)

/home/vdb/tmp/Iosevka/node_modules/libspiro-js/libspiro.js:218
        r[i].seg_ch = Math.hypot(dx, dy);
                           ^
TypeError: Object #<Object> has no method 'hypot'
    at setup_path (/home/vdb/tmp/Iosevka/node_modules/libspiro-js/libspiro.js:218:28)
    at run_spiro (/home/vdb/tmp/Iosevka/node_modules/libspiro-js/libspiro.js:581:13)
    at Object.spiroToBezierOnContext (/home/vdb/tmp/Iosevka/node_modules/libspiro-js/libspiro.js:614:13)
    at _r0_t5._r79_t0 (/home/vdb/tmp/Iosevka/support/spirokit.js:316:241)
    at _r0_t5._r0_t18 (/home/vdb/tmp/Iosevka/support/glyph.js:71:151)
    at _r0_t5._r236_t2 (/home/vdb/tmp/Iosevka/buildglyphs.js:707:31)
    at _r105_t171 (/home/vdb/tmp/Iosevka/buildglyphs.js:370:26)
    at _r105_t191 (/home/vdb/tmp/Iosevka/buildglyphs.js:700:16)
    at _r0_t5._r432_t0 (/home/vdb/tmp/Iosevka/buildglyphs.js:1434:39)
    at _r105_t171 (/home/vdb/tmp/Iosevka/buildglyphs.js:361:26)
onegroup.mk:49: recipe for target 'build/.pass0-iosevka-thin.fdt' failed
make[1]: *** [build/.pass0-iosevka-thin.fdt] Error 8
make[1]: Leaving directory '/home/vdb/tmp/Iosevka'
makefile:26: recipe for target 'fonts-default' failed
make: *** [fonts-default] Error 2

I have found a page which says Math.hypot function was added to node.js version 0.12, while my system has node.js 0.10.36.

Is that correct? If so, please update README.md and document this requirement.

@be5invis
Copy link
Owner

See #31, install core-js package and add a require(core-js) at the beginning of generator.js may fix this.
The version requirement is added to README.md either. I strongly recommend you to upgrade Node.js to the latest one since the older version may suffer from some bugs about GC.
Closed.

@van-de-bugger
Copy link
Author

Thanks, this works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants