Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with data edge_attr is None #1

Closed
dgm2 opened this issue Feb 9, 2022 · 4 comments
Closed

Issue with data edge_attr is None #1

dgm2 opened this issue Feb 9, 2022 · 4 comments
Assignees

Comments

@dgm2
Copy link

dgm2 commented Feb 9, 2022

Hello, Thanks for releasing the code.

I am getting an error in a few datasets (IMDB-B, PROTEINS) about edge_attr being None, as soon as this object is needed in the convolution.
Was this issue encountered before? or any possible suggestions?

Thanks

@beabevi
Copy link
Owner

beabevi commented Feb 9, 2022

Hello giame,

Can you be more specific on the configuration you are running?

@beabevi beabevi self-assigned this Feb 9, 2022
@dgm2
Copy link
Author

dgm2 commented Feb 9, 2022

  1. I have run data.py with the edge_deletion policy, (also tried some other policies), as follows:
    data.py --dataset=PROTEINS --policies=edge_deleted
    Here it seems that edge_attr is already None, in the dataset, so this seems to cause the issue in the next point.
    This script terminates successfully.

  2. in the model, it is required edge_attr: https://github.com/beabevi/ESAN/blob/master/models.py#L186

I run as follows: (model=deepsets, also tried model=gnn)
--dataset=PROTEINS --policy=edge_deleted --model=deepsets --gnn_type=gin
At this point getting error for edge_attr being None

I am running locally with pytorch-geometric 1.7.2

@beabevi
Copy link
Owner

beabevi commented Feb 9, 2022

For the TUDatasets you must use --gnn_type=originalgin.
Indeed, --gnn_type=gin uses edge_attr and it is used for ogbg datasets.

You can see which gnn_type is used for each dataset in the corresponding yaml file under configs/.

@dgm2
Copy link
Author

dgm2 commented Feb 9, 2022

Ah OK I was running with a wrong configuration.
I was able to run with your suggestion.
Thanks a lot!

@beabevi beabevi closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants