Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin -> Hosting and Tenant -> Page Variants: Validate total weight of all variants <= 100 #10

Closed
APB9785 opened this issue Aug 3, 2023 · 1 comment · Fixed by BeaconCMS/beacon#315
Closed

Admin -> Hosting and Tenant -> Page Variants: Validate total weight of all variants <= 100 #10

APB9785 opened this issue Aug 3, 2023 · 1 comment · Fixed by BeaconCMS/beacon#315
Assignees
@APB9785
Milestone
v0.1.0

Comments

@APB9785
Copy link
Collaborator

APB9785 commented Aug 3, 2023

Right now it is possible for sum(variant_weights) to exceed 100, in which case some variants will be rendered less frequently than expected. Ideally we could have an additional validation when updating a variant, to sum all the weights together and ensure that it's less than 100.
@AZholtkevych AZholtkevych changed the title Page Variants: Validate total weight of all variants <= 100 Admin -> Hosting and Tenant -> Page Variants: Validate total weight of all variants <= 100 Aug 4, 2023
@AZholtkevych AZholtkevych mentioned this issue Aug 8, 2023
Closed
29 tasks
@APB9785
Copy link
Collaborator Author

APB9785 commented Aug 9, 2023

Resolved by BeaconCMS/beacon#315

@APB9785 APB9785 closed this as completed Aug 9, 2023
@AZholtkevych AZholtkevych closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2023
@AZholtkevych AZholtkevych reopened this Aug 14, 2023
@AZholtkevych AZholtkevych linked a pull request Aug 14, 2023 that will close this issue
Validate total variant weights BeaconCMS/beacon#315
Merged
@AZholtkevych AZholtkevych added this to the Version 0.1.0 milestone Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@APB9785 APB9785

Labels
None yet
Projects
BeaconCMS
Status: Done
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Validate total variant weights BeaconCMS/beacon
2 participants
@APB9785 @AZholtkevych