Revert logging in server_io_callback #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer was used directly in g_message call, but there is no guarantee that it's going to be null terminated. Use logging as before removal of libssh.
danrodrig
changed the title
|
/test /packit build 👀 |
StykMartin
approved these changes
Apr 23, 2020
danrodrig
requested review from
renanrodrigo,
a team and
cbouchar
and removed request for
a team
cbouchar
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer was used directly in g_message call, but there is no guarantee
that it's going to be null terminated.
Use logging as before removal of libssh.
Fixes #45