fix: Replace calls to g_error #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrodrig
requested review from
a team,
cbouchar and
renanrodrigo
and removed request for
a team
cbouchar
reviewed
Apr 30, 2020
cbouchar
previously approved these changes
Apr 30, 2020
Calls to g_error result in core dump and they are not intended to report expected errors. Replace calls to g_error with g_warning and g_printerr. The later is preferred for reporting to the command line.
StykMartin
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to g_error result in core dump and they are not intended to report expected errors.
Replace calls to g_error with g_warning and g_printerr. The later is preferred for reporting to the command line.
Closes #53