Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

<button> elements have type="button" missing, causing autosubmitting forms #93

Closed
dorukgezici opened this issue Dec 26, 2022 · 3 comments

Comments

@dorukgezici
Copy link

dorukgezici commented Dec 26, 2022

Hey, thanks for the library!

I have just run into an edge case. My <Importer> is inside a <form>, so since the default type for buttons is "submit" and there is no type defined for the button IconButton, it tries to submit my form whenever I change the page while mapping fields.

I can work on a PR to define type="button" to stop auto-submitting forms if you would like. I currently am catching the faulty submits in my onSubmit function using a flag.

@unframework
Copy link
Collaborator

Oh that's a mistake on my part for sure! Thanks for reporting it, I should be able to make a PR by Monday ish.

@dorukgezici
Copy link
Author

Np, thanks for the fix!

@unframework
Copy link
Collaborator

Released in v0.8.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants