Transaction entry #426

aumayr · 2016-11-27T12:36:12Z

Implementation of #421

Basic UI
Mobile UI
Helpers for UI (autocomplete, formatting, adding new lines, etc.)
Data for autocomplete
Writing the resulting transaction to the beancount file
~~~Translations (ru, de)~~~ (shouldn't have to be part of feature-PR)
Tests
Documentation

This is a very big feature to implement, so any help is welcome!

aumayr · 2016-12-01T10:22:16Z

There are some issues/tasks still open:

Bug: "Save and add new" adds the same transaction multiple times
~~~make indentation configureable~~~
dropdown for flag
currency as input (awesomplete)?
multiple postings
~~~intelligent suggestions for account~~~
~~~tags? links?~~~
~~~metadata?~~~

yagebu · 2016-12-01T10:47:09Z

fava/api/file.py

@@ -32,3 +32,30 @@ def insert_line_in_file(filename, lineno, content):
    with open(filename, "w") as file:
        contents = "".join(contents)
        file.write(contents)
+
+
+def insert_transaction_in_file(filename, lineno, content):


This should really insert a data.Transaction and use parser.printer for it.

yagebu · 2016-12-01T10:47:43Z

Can you rebase this and fix tests/lint? Then I could help with some of the changes

aumayr · 2016-12-01T11:22:38Z

I rebased and fixed the tests/lint.

You can display the transaction form by using the keyboard shortcut n.

Please announce it (here or on Gitter) if you are working on changes, so we do not work on the same.

yagebu · 2016-12-01T15:41:03Z

Seems like you didn't push the rebase, will do that.

Also the autocomplete is currently shown in the wrong position, will fix the css for that and also hide some of the labels, I find placeholders are nicer. This way we can imitate the form looks more like a transaction in the file.

- fix position of autocomplete popup - use correct terms - placeholders instead of labels

aumayr · 2016-12-01T16:10:41Z

I find placeholders are nicer

Yes, this looks much nicer!

aumayr · 2016-12-01T16:17:29Z

@yagebu I guess you are adding the currencies-<list> and also still work on the JavaScript (as currencies is now an input, not a select)?

yagebu · 2016-12-01T16:18:02Z

Yes just started with improving the completions a bit.

aumayr · 2016-12-01T16:21:09Z

Yes just started with improving the completions a bit.

The algorithm(s) for suggesting the account based on the payee, narration and/or other account are an interesting (and seemingly hard) part. Also, these algorithms could be used (or extended) for implementing a UI for bean-extract, as suggested in #421 (comment)

yagebu · 2016-12-01T16:28:04Z

The algorithm(s) for suggesting the account based on the payee, narration and/or other account are an interesting (and seemingly hard) part. Also, these algorithms could be used (or extended) for implementing a UI for bean-extract, as suggested in #421 (comment)

Right now, I'm only working on the JS part to do fuzzy matchings (and only suggest active accounts). That already goes a long way.

yagebu · 2016-12-01T17:14:20Z

I've added an input for the flag - it's "cheap" as it has a default and value and can simply be skipped. I'm against supporting links, tags and metadata - it doesn't even support costs atm (and I'm fine with that, it's meant for simple transactions IMHO).

yagebu · 2016-12-02T19:32:20Z

fava/templates/overlays/_transaction_form.html

-                <input type="number" step="0.01" class="number" name="number" placeholder="Number" />
-                <input type="text" class="currency" name="currency" placeholder="Currency" list="currencies" />
+            <div class="postings">
+            {% for i in range(15) %}


This seems like a waste of bandwidth. cloneNode should do the trick

aumayr · 2016-12-08T17:25:40Z

Should I bake a new release? Doing so would force everyone to use the new
booking code, which is vastly better, but still has a remaining flaw (which
I want to fix soon): https://bitbucket.org/blais/beancount/issues/145

For development we use the current code from bitbucket. I guess when this feature is complete we release a new version, for which we would need a new version/release of beancount as well (for people installing via pip). We will ping you once this is approaching.

aumayr · 2016-12-10T12:37:35Z

The currency-input should change it's width for the last row, so it makes space for the "+" and the number inputs are all the same width and neatly vertically aligned.

Currently it looks like this:

@yagebu Do you know how to achieve that?

yagebu · 2016-12-10T14:53:50Z

fava/templates/overlays/_transaction_form.html

-            {% for i in range(2) %}
-                <div class="fieldset posting">
+            {% for i in range(3) %}
+                <div class="fieldset posting{% if i == 0 %} template{% endif %}">


I don't see the need for this superfluous element. What was wrong with my code?

Previous to this change, if you add new posting rows with the "+" the inputs in those rows were not awesomplete-initialized, so there was no auto-complete of them.

Background:
When cloning the .posting-row after pressing "+", the nodes generated by awesomplete were cloned, and the auto-completion did not "carry over" to those nodes, as the list="..."-property got removed by awesomplete.

Makes sense, thanks for the explanation!

yagebu · 2016-12-10T14:59:46Z

This now uses a (very stupid) handwritten printer that should address most of the concerns above.

I always use two decimal places for EUR. There is no way to configure how many should be added/shown/inserted.

Currently it simply uses whatever the user inputs -- which seems the right thing to do to me.

Currently it looks like this:

That's the look I was going for, I didn't like the tiny currency input. Changing the width's in the conditional last-child code would be the way to change it.

yagebu · 2016-12-10T15:08:42Z

That's the look I was going for, I didn't like the tiny currency input. Changing the width's in the conditional last-child code would be the way to change it.

This should be understood as a "feel free to change it, I don't care much" ;)

yagebu · 2016-12-10T15:15:03Z

The "+"-button and keyboard shortcut are not working when on the Editor page

Can't reproduce. (Of course when the editor is focused the keyboard shortcut doesn't work, but otherwise the shortcut and the button work for me)

aumayr · 2016-12-10T15:17:57Z

The "+"-button and keyboard shortcut are not working when on the Editor page

Can't reproduce. (Of course when the editor is focused the keyboard shortcut doesn't work, but otherwise the shortcut and the button work for me)

It works now - sorry for the confusion!

aumayr · 2016-12-14T18:40:13Z

There are just two tasks open:

When clicking into the results list from awesomplete and the result clicked on is outside the bounds of the overlay, the overlay is dismissed. I tried to fix this, but somehow magically a MouseEvent appears when calling input.close() on the Awesomplete-element. So basically I don't know how to fix this. @yagebu Do you have any clue why this happens?
Fix the styling for mobile browsers.

After this is complete, Documentation and Translation have to be added as well.

Also includes optimizations for mobile browsers

yagebu · 2016-12-17T12:02:51Z

When clicking into the results list from awesomplete and the result clicked on is outside the bounds of the overlay, the overlay is dismissed. I tried to fix this, but somehow magically a MouseEvent appears when calling input.close() on the Awesomplete-element. So basically I don't know how to fix this. @yagebu Do you have any clue why this happens?

Awesomplete listened to mousedown and we to click (which is basically mousedown+mouseup) which would fire after the list had been closed already.

yagebu · 2016-12-17T13:15:17Z

fava/static/sass/_base.scss

    left: $aside-width;
  }
 }

+.add-transaction-button {
+  background-color: $color-sidebar-background;
+  color: $color-journaltable-header;


this is definitely not a variable that should be used here

yagebu · 2016-12-17T13:15:22Z

fava/static/sass/_base.scss

@@ -584,6 +608,10 @@ td {

    &.active {
      margin-left: 0;
+
+      .add-transaction-button {
+        left: 160px;


try not to use random constants like this one, we've got variables for this.

yagebu · 2016-12-17T13:15:35Z

fava/static/sass/_base.scss

+    height: 41px;
+    left: 0;
+    position: fixed;
+    top: 95px;


aumayr · 2016-12-17T13:46:55Z

@fokusov Could you provide the Russian translation strings?

fokusov · 2016-12-17T13:50:14Z

@aumayr Yes, I'm working on it

@fokusov Could you provide the Russian translation strings?

fokusov · 2016-12-17T14:21:35Z

@aumayr I can't find no new translated strings with make babel-extract in updated templates :(

aumayr · 2016-12-17T14:38:42Z

@fokusov Oh, there seem to be no new strings to translate after all 😃 I thought I had translated new parts for German before and the Russian counterparts were missing, but that does not seem to be the case.

Anyhow, thanks for the help!

aumayr added the feature label Nov 27, 2016

yagebu reviewed Dec 1, 2016

View reviewed changes

aumayr and others added 6 commits December 1, 2016 16:55

Add basic UI for transaction input overlay

ceff4b9

Add mobile stylesheets

528fbe2

Autocomplete for payee

7ff11f5

Store transaction in file, tests

eddfe32

Lint

18e1fe5

transaction-form: cleanup, change desktop css

eadbec2

- fix position of autocomplete popup - use correct terms - placeholders instead of labels

yagebu force-pushed the transaction-input-form branch from 44143ec to eadbec2 Compare December 1, 2016 15:56

yagebu added 4 commits December 1, 2016 17:34

transaction-form: improve autocomplete

b04e5c6

insert_metadata_in_file: do what it says

473a8bd

add input for flag

91108fc

small bug

1320bc1

yagebu and others added 3 commits December 1, 2016 19:22

wip: transaction-form: use proper data types, book and validate

09d422c

transaction-form: reimplement saving

69d501c

Button to add more posting rows

8ab6562

yagebu reviewed Dec 2, 2016

View reviewed changes

yagebu added 2 commits December 2, 2016 23:21

transaction-form: add postings using JS; sass cleanup

5b1f7e2

cleanup sass mess some more

3c58864

yagebu force-pushed the transaction-input-form branch from e0327b6 to 3c58864 Compare December 2, 2016 22:21

yagebu and others added 2 commits December 8, 2016 20:42

use own transaction printer

d60fc7c

Initialize awesomplete on new posting rows

d7cc6fd

yagebu reviewed Dec 10, 2016

View reviewed changes

aumayr added 2 commits December 10, 2016 16:22

Align input fields

99c305a

When adding another transaction, preserve the date

3403977

aumayr and others added 4 commits December 14, 2016 20:06

Adapt styling for mobile browsers

ec0c4e9

Style add transaction button

82a65b2

Also includes optimizations for mobile browsers

transaction-form: posting-row template

d652f62

fix #432

c26723d

aumayr mentioned this pull request Dec 15, 2016

Transaction entry: Intelligent suggestions #433

Closed

yagebu reviewed Dec 17, 2016

View reviewed changes

fava/static/sass/_base.scss

height: 41px;

left: 0;

position: fixed;

top: 95px;

Copy link

Member

yagebu Dec 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

some sass cleanup

a186481

yagebu merged commit 8d097c0 into master Dec 17, 2016

yagebu modified the milestone: 1.2 Dec 25, 2016

yagebu deleted the transaction-input-form branch January 19, 2017 18:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transaction entry #426

Transaction entry #426

aumayr commented Nov 27, 2016 •

edited

aumayr commented Dec 1, 2016 •

edited

yagebu Dec 1, 2016

yagebu commented Dec 1, 2016

aumayr commented Dec 1, 2016

yagebu commented Dec 1, 2016

aumayr commented Dec 1, 2016

aumayr commented Dec 1, 2016

yagebu commented Dec 1, 2016

aumayr commented Dec 1, 2016

yagebu commented Dec 1, 2016

yagebu commented Dec 1, 2016

yagebu Dec 2, 2016

aumayr commented Dec 8, 2016

aumayr commented Dec 10, 2016

yagebu Dec 10, 2016

aumayr Dec 10, 2016

yagebu Dec 10, 2016

yagebu commented Dec 10, 2016

yagebu commented Dec 10, 2016

yagebu commented Dec 10, 2016

aumayr commented Dec 10, 2016 •

edited

aumayr commented Dec 14, 2016 •

edited

yagebu commented Dec 17, 2016

yagebu Dec 17, 2016

yagebu Dec 17, 2016

yagebu Dec 17, 2016

aumayr commented Dec 17, 2016

fokusov commented Dec 17, 2016

fokusov commented Dec 17, 2016

aumayr commented Dec 17, 2016

Transaction entry #426

Transaction entry #426

Conversation

aumayr commented Nov 27, 2016 • edited

aumayr commented Dec 1, 2016 • edited

Choose a reason for hiding this comment

yagebu commented Dec 1, 2016

aumayr commented Dec 1, 2016

yagebu commented Dec 1, 2016

aumayr commented Dec 1, 2016

aumayr commented Dec 1, 2016

yagebu commented Dec 1, 2016

aumayr commented Dec 1, 2016

yagebu commented Dec 1, 2016

yagebu commented Dec 1, 2016

Choose a reason for hiding this comment

aumayr commented Dec 8, 2016

aumayr commented Dec 10, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yagebu commented Dec 10, 2016

yagebu commented Dec 10, 2016

yagebu commented Dec 10, 2016

aumayr commented Dec 10, 2016 • edited

aumayr commented Dec 14, 2016 • edited

yagebu commented Dec 17, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aumayr commented Dec 17, 2016

fokusov commented Dec 17, 2016

fokusov commented Dec 17, 2016

aumayr commented Dec 17, 2016

aumayr commented Nov 27, 2016 •

edited

aumayr commented Dec 1, 2016 •

edited

aumayr commented Dec 10, 2016 •

edited

aumayr commented Dec 14, 2016 •

edited