BVAL-690 Clarifying semantics of getLeafBean() for container-element … #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnarmorling
commented
Jul 6, 2017
| ---- | ||
| //assuming an english locale, the interpolated message is returned |
There was a problem hiding this comment.
These sections don't have changed at all, I just pulled the into actual source files to be sure they compile and are correct.
gsmet
reviewed
Jul 6, 2017
sources/validation-api.asciidoc
Outdated
| @@ -456,10 +456,10 @@ include::{validation-api-source-dir}javax/validation/ConstraintViolation.java[li | |||
| The [methodname]`getLeafBean()` method returns the following object: | |||
|
|
|||
| * If a bean constraint, the bean instance the constraint is applied on. | |||
| * If a property constraint, the bean instance hosting the property the constraint is applied on. | |||
| * If a property constraint or a <<constraintdeclarationvalidationprocess-containerelementconstraints,container-element constraint>> hosted on a property, the bean instance hosting the property the constraint is applied on. | |||
There was a problem hiding this comment.
Same remark about the hyphen.
…constraints; Also expending the example to cover that case
|
Rebased and merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…constraints;
Also expending the example to cover that case
https://hibernate.atlassian.net/browse/BVAL-690