Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BVTCK-114 Add tests for the support of group conversion for container…
… element types
- Loading branch information
1 parent
1840240
commit 0e0dc18
Showing
3 changed files
with
877 additions
and
0 deletions.
There are no files selected for viewing
381 changes: 381 additions & 0 deletions
381
...n/tck/tests/validation/groupconversion/ContainerElementGroupConversionValidationTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,381 @@ | ||
| /** | ||
| * Bean Validation TCK | ||
| * | ||
| * License: Apache License, Version 2.0 | ||
| * See the license.txt file in the root directory or <http://www.apache.org/licenses/LICENSE-2.0>. | ||
| */ | ||
| package org.hibernate.beanvalidation.tck.tests.validation.groupconversion; | ||
|
|
||
| import static org.hibernate.beanvalidation.tck.util.ConstraintViolationAssert.pathWith; | ||
| import static org.hibernate.beanvalidation.tck.util.ConstraintViolationAssert.ConstraintViolationSetAssert.assertContainsOnlyPaths; | ||
| import static org.hibernate.beanvalidation.tck.util.TestUtil.assertCorrectNumberOfViolations; | ||
| import static org.hibernate.beanvalidation.tck.util.TestUtil.assertDescriptorKinds; | ||
| import static org.hibernate.beanvalidation.tck.util.TestUtil.assertNodeNames; | ||
| import static org.hibernate.beanvalidation.tck.util.TestUtil.webArchiveBuilder; | ||
|
|
||
| import java.lang.reflect.Constructor; | ||
| import java.lang.reflect.Method; | ||
| import java.time.Year; | ||
| import java.util.Arrays; | ||
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
|
|
||
| import javax.validation.ConstraintViolation; | ||
| import javax.validation.ElementKind; | ||
| import javax.validation.Path; | ||
| import javax.validation.groups.Default; | ||
|
|
||
| import org.hibernate.beanvalidation.tck.beanvalidation.Sections; | ||
| import org.hibernate.beanvalidation.tck.tests.BaseExecutableValidatorTest; | ||
| import org.hibernate.beanvalidation.tck.util.TestUtil; | ||
| import org.jboss.arquillian.container.test.api.Deployment; | ||
| import org.jboss.shrinkwrap.api.spec.WebArchive; | ||
| import org.jboss.test.audit.annotations.SpecAssertion; | ||
| import org.jboss.test.audit.annotations.SpecVersion; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| /** | ||
| * @author Guillaume Smet | ||
| */ | ||
| @SpecVersion(spec = "beanvalidation", version = "2.0.0") | ||
| public class ContainerElementGroupConversionValidationTest extends BaseExecutableValidatorTest { | ||
|
|
||
| @Deployment | ||
| public static WebArchive createTestArchive() { | ||
| return webArchiveBuilder() | ||
| .withTestClassPackage( ContainerElementGroupConversionValidationTest.class ) | ||
| .build(); | ||
| } | ||
|
|
||
| @Test | ||
| // FIXME: update spec assertions | ||
| @SpecAssertion(section = Sections.CONSTRAINTDECLARATIONVALIDATIONPROCESS_GROUPSEQUENCE_GROUPCONVERSION, id = "c") | ||
| @SpecAssertion(section = Sections.CONSTRAINTDECLARATIONVALIDATIONPROCESS_VALIDATIONROUTINE, id = "a") | ||
| public void testGroupConversionIsAppliedOnField() { | ||
| Set<ConstraintViolation<RegisteredAddresses>> constraintViolations = getValidator().validate( TestRegisteredAddresses.withInvalidMainAddress() ); | ||
|
|
||
|
|
||
| assertContainsOnlyPaths( constraintViolations, | ||
| pathWith() | ||
| .property( "mainAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "street1", true, null, 1, List.class, 0 ), | ||
| pathWith() | ||
| .property( "mainAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "zipCode", true, null, 1, List.class, 0 ) | ||
| ); | ||
| } | ||
|
|
||
| @Test | ||
| // FIXME: update spec assertions | ||
| @SpecAssertion(section = Sections.CONSTRAINTDECLARATIONVALIDATIONPROCESS_GROUPSEQUENCE_GROUPCONVERSION, id = "c") | ||
| @SpecAssertion(section = Sections.CONSTRAINTDECLARATIONVALIDATIONPROCESS_VALIDATIONROUTINE, id = "a") | ||
| public void testSeveralGroupConversionsAppliedOnField() { | ||
| RegisteredAddresses registeredAddressesWithInvalidPreferredShipmentAddress = TestRegisteredAddresses.withInvalidPreferredShipmentAddress(); | ||
|
|
||
| Set<ConstraintViolation<RegisteredAddresses>> constraintViolations = getValidator().validate( | ||
| registeredAddressesWithInvalidPreferredShipmentAddress | ||
| ); | ||
|
|
||
| assertContainsOnlyPaths( constraintViolations, | ||
| pathWith() | ||
| .property( "preferredShipmentAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "street1", true, null, 1, List.class, 0 ), | ||
| pathWith() | ||
| .property( "preferredShipmentAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "zipCode", true, null, 1, List.class, 0 ) ); | ||
|
|
||
| constraintViolations = getValidator().validate( | ||
| registeredAddressesWithInvalidPreferredShipmentAddress, | ||
| Complex.class | ||
| ); | ||
|
|
||
| assertContainsOnlyPaths( constraintViolations, | ||
| pathWith() | ||
| .property( "preferredShipmentAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property("doorCode", true, null, 1, List.class, 0 ) | ||
| ); | ||
|
|
||
| constraintViolations = getValidator().validate( | ||
| registeredAddressesWithInvalidPreferredShipmentAddress, | ||
| Default.class, | ||
| Complex.class | ||
| ); | ||
|
|
||
| assertContainsOnlyPaths( constraintViolations, | ||
| pathWith() | ||
| .property( "preferredShipmentAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "street1", true, null, 1, List.class, 0 ), | ||
| pathWith() | ||
| .property( "preferredShipmentAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "zipCode", true, null, 1, List.class, 0 ), | ||
| pathWith() | ||
| .property( "preferredShipmentAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "doorCode", true, null, 1, List.class, 0 ) | ||
| ); | ||
|
|
||
| constraintViolations = getValidator().validate( | ||
| registeredAddressesWithInvalidPreferredShipmentAddress, | ||
| Complete.class | ||
| ); | ||
|
|
||
| assertContainsOnlyPaths( constraintViolations, | ||
| pathWith() | ||
| .property( "preferredShipmentAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "street1", true, null, 1, List.class, 0 ), | ||
| pathWith() | ||
| .property( "preferredShipmentAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "zipCode", true, null, 1, List.class, 0 ), | ||
| pathWith() | ||
| .property( "preferredShipmentAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "doorCode", true, null, 1, List.class, 0 ) | ||
| ); | ||
| } | ||
|
|
||
| @Test | ||
| // FIXME: update spec assertions | ||
| @SpecAssertion(section = Sections.CONSTRAINTDECLARATIONVALIDATIONPROCESS_GROUPSEQUENCE_GROUPCONVERSION, id = "c") | ||
| public void testGroupConversionIsAppliedOnProperty() { | ||
| Set<ConstraintViolation<RegisteredAddresses>> constraintViolations = getValidator().validate( TestRegisteredAddresses.withInvalidShipmentAddress() ); | ||
|
|
||
| assertContainsOnlyPaths( constraintViolations, | ||
| pathWith() | ||
| .property( "shipmentAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "street1", true, null, 1, List.class, 0 ), | ||
| pathWith() | ||
| .property( "shipmentAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "zipCode", true, null, 1, List.class, 0 ) | ||
| ); | ||
| } | ||
|
|
||
| @Test | ||
| // FIXME: update spec assertions | ||
| @SpecAssertion(section = Sections.CONSTRAINTDECLARATIONVALIDATIONPROCESS_GROUPSEQUENCE_GROUPCONVERSION, id = "c") | ||
| public void testGroupConversionIsAppliedOnMethodReturnValue() throws Exception { | ||
| //given | ||
| RegisteredAddresses registeredAddresses = TestRegisteredAddresses.validRegisteredAddresses(); | ||
| Method method = RegisteredAddresses.class.getMethod( "retrieveMainAddresses" ); | ||
| Object returnValue = TestAddresses.wrap( TestAddresses.withInvalidStreet1() ); | ||
|
|
||
| //when | ||
| Set<ConstraintViolation<RegisteredAddresses>> constraintViolations = getExecutableValidator() | ||
| .validateReturnValue( registeredAddresses, method, returnValue ); | ||
|
|
||
| //then | ||
| assertCorrectNumberOfViolations( constraintViolations, 1 ); | ||
|
|
||
| Path propertyPath = constraintViolations.iterator().next().getPropertyPath(); | ||
|
|
||
| assertDescriptorKinds( propertyPath, ElementKind.METHOD, ElementKind.RETURN_VALUE, ElementKind.CONTAINER_ELEMENT, ElementKind.PROPERTY ); | ||
| assertNodeNames( propertyPath, "retrieveMainAddresses", TestUtil.RETURN_VALUE_NODE_NAME, "<map value>", "street1" ); | ||
| } | ||
|
|
||
| @Test | ||
| // FIXME: update spec assertions | ||
| @SpecAssertion(section = Sections.CONSTRAINTDECLARATIONVALIDATIONPROCESS_GROUPSEQUENCE_GROUPCONVERSION, id = "c") | ||
| public void testGroupConversionIsAppliedOnMethodParameter() throws Exception { | ||
| //given | ||
| RegisteredAddresses registeredAddresses = TestRegisteredAddresses.validRegisteredAddresses(); | ||
| Method method = RegisteredAddresses.class.getMethod( "setMainAddress", Map.class ); | ||
| Object[] arguments = new Object[] { TestAddresses.wrap( TestAddresses.withInvalidStreet1() ) }; | ||
|
|
||
| //when | ||
| Set<ConstraintViolation<RegisteredAddresses>> constraintViolations = getExecutableValidator() | ||
| .validateParameters( registeredAddresses, method, arguments ); | ||
|
|
||
| //then | ||
| assertCorrectNumberOfViolations( constraintViolations, 1 ); | ||
|
|
||
| Path propertyPath = constraintViolations.iterator().next().getPropertyPath(); | ||
|
|
||
| assertDescriptorKinds( propertyPath, ElementKind.METHOD, ElementKind.PARAMETER, ElementKind.CONTAINER_ELEMENT, ElementKind.PROPERTY ); | ||
| assertNodeNames( propertyPath, "setMainAddress", "mainAddresses", "<map value>", "street1" ); | ||
| } | ||
|
|
||
| @Test | ||
| // FIXME: update spec assertions | ||
| @SpecAssertion(section = Sections.CONSTRAINTDECLARATIONVALIDATIONPROCESS_GROUPSEQUENCE_GROUPCONVERSION, id = "c") | ||
| public void testGroupConversionIsAppliedOnConstructorReturnValue() throws Exception { | ||
| //given | ||
| Constructor<RegisteredAddresses> constructor = RegisteredAddresses.class.getConstructor( Map.class ); | ||
| RegisteredAddresses createdObject = TestRegisteredAddresses.withMainAddressInvalidStreet1(); | ||
|
|
||
| //when | ||
| Set<ConstraintViolation<RegisteredAddresses>> constraintViolations = getExecutableValidator() | ||
| .validateConstructorReturnValue( constructor, createdObject ); | ||
|
|
||
| //then | ||
| assertCorrectNumberOfViolations( constraintViolations, 1 ); | ||
|
|
||
| Path propertyPath = constraintViolations.iterator().next().getPropertyPath(); | ||
|
|
||
| assertDescriptorKinds( | ||
| propertyPath, | ||
| ElementKind.CONSTRUCTOR, | ||
| ElementKind.RETURN_VALUE, | ||
| ElementKind.PROPERTY, | ||
| ElementKind.CONTAINER_ELEMENT, | ||
| ElementKind.PROPERTY | ||
| ); | ||
| assertNodeNames( propertyPath, "RegisteredAddresses", TestUtil.RETURN_VALUE_NODE_NAME, "mainAddresses", "<map value>", "street1" ); | ||
| } | ||
|
|
||
| @Test | ||
| // FIXME: update spec assertions | ||
| @SpecAssertion(section = Sections.CONSTRAINTDECLARATIONVALIDATIONPROCESS_GROUPSEQUENCE_GROUPCONVERSION, id = "c") | ||
| public void testGroupConversionIsAppliedOnConstructorParameter() throws Exception { | ||
| //given | ||
| Constructor<RegisteredAddresses> constructor = RegisteredAddresses.class.getConstructor( Map.class ); | ||
| Object[] arguments = new Object[] { TestAddresses.wrap( TestAddresses.withInvalidStreet1() ) }; | ||
|
|
||
| //when | ||
| Set<ConstraintViolation<RegisteredAddresses>> constraintViolations = getExecutableValidator() | ||
| .validateConstructorParameters( constructor, arguments ); | ||
|
|
||
| //then | ||
| assertCorrectNumberOfViolations( constraintViolations, 1 ); | ||
|
|
||
| Path propertyPath = constraintViolations.iterator().next().getPropertyPath(); | ||
|
|
||
| assertDescriptorKinds( propertyPath, ElementKind.CONSTRUCTOR, ElementKind.PARAMETER, ElementKind.CONTAINER_ELEMENT, ElementKind.PROPERTY ); | ||
| assertNodeNames( propertyPath, "RegisteredAddresses", "mainAddresses", "<map value>", "street1" ); | ||
| } | ||
|
|
||
| @Test | ||
| // FIXME: update spec assertions | ||
| @SpecAssertion(section = Sections.CONSTRAINTDECLARATIONVALIDATIONPROCESS_GROUPSEQUENCE_GROUPCONVERSION, id = "d") | ||
| public void testGroupConversionIsNotExecutedRecursively() { | ||
| Set<ConstraintViolation<RegisteredAddresses>> constraintViolations = getValidator().validate( TestRegisteredAddresses.withInvalidOfficeAddress() ); | ||
|
|
||
| assertContainsOnlyPaths( constraintViolations, | ||
| pathWith() | ||
| .property( "officeAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "street1", true, null, 1, List.class, 0 ), | ||
| pathWith() | ||
| .property( "officeAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "zipCode", true, null, 1, List.class, 0 ) | ||
| ); | ||
|
|
||
| constraintViolations = getValidator().validate( | ||
| TestRegisteredAddresses.withInvalidOfficeAddress(), | ||
| BasicPostal.class | ||
| ); | ||
|
|
||
| assertContainsOnlyPaths( constraintViolations, | ||
| pathWith() | ||
| .property( "officeAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "doorCode", true, null, 1, List.class, 0 ) | ||
| ); | ||
| } | ||
|
|
||
| @Test | ||
| // FIXME: update spec assertions | ||
| @SpecAssertion(section = Sections.CONSTRAINTDECLARATIONVALIDATIONPROCESS_GROUPSEQUENCE_GROUPCONVERSION, id = "g") | ||
| public void testGroupConversionWithSequenceAsTo() { | ||
| RegisteredAddresses registeredAddresses = TestRegisteredAddresses.validRegisteredAddresses(); | ||
|
|
||
| Set<ConstraintViolation<RegisteredAddresses>> constraintViolations = getValidator().validate( registeredAddresses ); | ||
| assertCorrectNumberOfViolations( constraintViolations, 0 ); | ||
|
|
||
| registeredAddresses.getWeekendAddresses().get( TestRegisteredAddresses.REFERENCE_YEAR ).get( 0 ).setDoorCode( "ABC" ); | ||
| constraintViolations = getValidator().validate( registeredAddresses ); | ||
| assertContainsOnlyPaths( constraintViolations, | ||
| pathWith() | ||
| .property( "weekendAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "doorCode", true, null, 0, List.class, 0 ) | ||
| ); | ||
|
|
||
| registeredAddresses.getWeekendAddresses().get( TestRegisteredAddresses.REFERENCE_YEAR ).get( 0 ).setStreet1( null ); | ||
| constraintViolations = getValidator().validate( registeredAddresses ); | ||
| assertContainsOnlyPaths( constraintViolations, | ||
| pathWith() | ||
| .property( "weekendAddresses" ) | ||
| .containerElement( "<map value>", true, TestRegisteredAddresses.REFERENCE_YEAR, null, Map.class, 1 ) | ||
| .property( "street1", true, null, 0, List.class, 0 ) ); | ||
| } | ||
|
|
||
| private static class TestRegisteredAddresses { | ||
|
|
||
| public final static Year REFERENCE_YEAR = Year.of(2016); | ||
|
|
||
| public static RegisteredAddresses validRegisteredAddresses() { | ||
| return new RegisteredAddresses() | ||
| .addMainAddress( REFERENCE_YEAR, TestAddresses.validAddress() ) | ||
| .addShipmentAddress( REFERENCE_YEAR, TestAddresses.validAddress() ) | ||
| .addPreferredShipmentAddress( REFERENCE_YEAR, TestAddresses.validAddress() ) | ||
| .addOfficeAddress( REFERENCE_YEAR, TestAddresses.validAddress() ) | ||
| .addWeekendAddress( REFERENCE_YEAR, TestAddresses.validAddress() ); | ||
| } | ||
|
|
||
| public static RegisteredAddresses withInvalidMainAddress() { | ||
| RegisteredAddresses registeredAddresses = validRegisteredAddresses(); | ||
| registeredAddresses.addMainAddress( REFERENCE_YEAR, TestAddresses.invalidAddress() ); | ||
| return registeredAddresses; | ||
| } | ||
|
|
||
| public static RegisteredAddresses withMainAddressInvalidStreet1() { | ||
| RegisteredAddresses registeredAddresses = validRegisteredAddresses(); | ||
| registeredAddresses.addMainAddress( REFERENCE_YEAR, TestAddresses.withInvalidStreet1() ); | ||
| return registeredAddresses; | ||
| } | ||
|
|
||
| public static RegisteredAddresses withInvalidShipmentAddress() { | ||
| RegisteredAddresses registeredAddresses = validRegisteredAddresses(); | ||
| registeredAddresses.addShipmentAddress( REFERENCE_YEAR, TestAddresses.invalidAddress() ); | ||
| return registeredAddresses; | ||
| } | ||
|
|
||
| public static RegisteredAddresses withInvalidPreferredShipmentAddress() { | ||
| RegisteredAddresses registeredAddresses = validRegisteredAddresses(); | ||
| registeredAddresses.addPreferredShipmentAddress( REFERENCE_YEAR, TestAddresses.invalidAddress() ); | ||
| return registeredAddresses; | ||
| } | ||
|
|
||
| public static RegisteredAddresses withInvalidOfficeAddress() { | ||
| RegisteredAddresses registeredAddresses = validRegisteredAddresses(); | ||
| registeredAddresses.addOfficeAddress( REFERENCE_YEAR, TestAddresses.invalidAddress() ); | ||
| return registeredAddresses; | ||
| } | ||
| } | ||
|
|
||
| private static class TestAddresses { | ||
|
|
||
| public static Address validAddress() { | ||
| return new Address( "Main Street", "c/o Hitchcock", "123", "AB" ); | ||
| } | ||
|
|
||
| public static Address invalidAddress() { | ||
| return new Address( null, null, "12", "ABC" ); | ||
| } | ||
|
|
||
| public static Address withInvalidStreet1() { | ||
| Address address = validAddress(); | ||
| address.setStreet1( null ); | ||
| return address; | ||
| } | ||
|
|
||
| public static Map<Year, List<Address>> wrap(Address address) { | ||
| Map<Year, List<Address>> addresses = new HashMap<>(); | ||
| addresses.put( TestRegisteredAddresses.REFERENCE_YEAR, Arrays.asList( address ) ); | ||
| return addresses; | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.