Skip to content

Commit

Permalink
BVTCK-32 Enabling tests fixed by HV-646, HV-664 and HV-677
Browse files Browse the repository at this point in the history
  • Loading branch information
@gunnarmorling
gunnarmorling committed Feb 5, 2013
1 parent afbe402 commit b794285
Showing 1 changed file with 28 additions and 36 deletions.
64 changes: 28 additions & 36 deletions tests/src/main/java/org/hibernate/beanvalidation/tck/tests/validation/PropertyPathTest.java
View file
Expand Up @@ -279,7 +279,7 @@ public void testPropertyPathSet() {
assertFalse( nodeIter.hasNext() );
}

//fails due to traversable resolver not handling method arguments
//Fails due to HV-673
@Test(groups = Groups.FAILING_IN_RI)
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
Expand Down Expand Up @@ -320,7 +320,7 @@ public void testPropertyPathForMethodParameterConstraint() throws Exception {
);
}

//fails due to traversable resolver not handling method arguments
//Fails due to HV-673
@Test(groups = Groups.FAILING_IN_RI)
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
Expand Down Expand Up @@ -362,8 +362,7 @@ public void testPropertyPathForMethodParameterConstraintWithCustomParameterNameP
);
}

//Fails on RI due to wrong return value name
@Test(groups = Groups.FAILING_IN_RI)
@Test
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
@SpecAssertion(section = "5.2", id = "p"),
Expand Down Expand Up @@ -398,7 +397,7 @@ public void testPropertyPathForMethodReturnValueConstraint() throws Exception {
);
}

//fails due to traversable resolver not handling method arguments
//Fails due to HV-673
@Test(groups = Groups.FAILING_IN_RI)
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
Expand Down Expand Up @@ -434,7 +433,7 @@ public void testPropertyPathForConstructorParameterConstraint() throws Exception
);
}

//fails due to traversable resolver not handling method arguments
//Fails due to HV-673
@Test(groups = Groups.FAILING_IN_RI)
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
Expand Down Expand Up @@ -471,8 +470,7 @@ public void testPropertyPathForConstructorParameterConstraintWithCustomParameter
);
}

//Fails due to wrong return value name
@Test(groups = Groups.FAILING_IN_RI)
@Test
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
@SpecAssertion(section = "5.2", id = "p"),
Expand Down Expand Up @@ -502,7 +500,7 @@ public void testPropertyPathForConstructorReturnValueConstraint() throws Excepti
);
}

//fails due to traversable resolver not handling method arguments
//Fails due to HV-673
@Test(groups = Groups.FAILING_IN_RI)
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
Expand Down Expand Up @@ -553,7 +551,7 @@ public void testPropertyPathTraversingMethodParameter() throws Exception {
assertFalse( nodeIter.hasNext() );
}

//fails due to traversable resolver not handling method arguments
//Fails due to HV-673
@Test(groups = Groups.FAILING_IN_RI)
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
Expand Down Expand Up @@ -609,7 +607,7 @@ public void testPropertyPathTraversingMethodListParameter() throws Exception {
assertFalse( nodeIter.hasNext() );
}

//fails on RI due to https://hibernate.onjira.com/browse/HV-677
//Fails due to HV-673
@Test(groups = Groups.FAILING_IN_RI)
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
Expand Down Expand Up @@ -665,7 +663,7 @@ public void testPropertyPathTraversingMethodArrayParameter() throws Exception {
assertFalse( nodeIter.hasNext() );
}

//fails on RI due to https://hibernate.onjira.com/browse/HV-646
//Fails due to HV-673
@Test(groups = Groups.FAILING_IN_RI)
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
Expand Down Expand Up @@ -717,7 +715,7 @@ public void testPropertyPathTraversingMethodSetParameter() throws Exception {
assertFalse( nodeIter.hasNext() );
}

//fails on RI due to https://hibernate.onjira.com/browse/HV-677
//Fails due to HV-673
@Test(groups = Groups.FAILING_IN_RI)
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
Expand Down Expand Up @@ -773,7 +771,7 @@ public void testPropertyPathTraversingMethodMapParameter() throws Exception {
assertFalse( nodeIter.hasNext() );
}

//fails due to traversable resolver not handling method arguments
//Fails due to HV-673
@Test(groups = Groups.FAILING_IN_RI)
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
Expand Down Expand Up @@ -815,7 +813,7 @@ public void testPropertyPathTraversingConstructorParameter() throws Exception {
assertFalse( nodeIter.hasNext() );
}

//fails due to traversable resolver not handling method arguments
//Fails due to HV-673
@Test(groups = Groups.FAILING_IN_RI)
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
Expand Down Expand Up @@ -867,7 +865,7 @@ public void testPropertyPathTraversingConstructorListParameter() throws Exceptio
assertFalse( nodeIter.hasNext() );
}

//fails on RI due to https://hibernate.onjira.com/browse/HV-677
//Fails due to HV-673
@Test(groups = Groups.FAILING_IN_RI)
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
Expand Down Expand Up @@ -919,7 +917,7 @@ public void testPropertyPathTraversingConstructorArrayParameter() throws Excepti
assertFalse( nodeIter.hasNext() );
}

//fails on RI due to https://hibernate.onjira.com/browse/HV-646
//Fails due to HV-673
@Test(groups = Groups.FAILING_IN_RI)
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
Expand Down Expand Up @@ -967,7 +965,7 @@ public void testPropertyPathTraversingConstructorSetParameter() throws Exception
assertFalse( nodeIter.hasNext() );
}

//fails on RI due to https://hibernate.onjira.com/browse/HV-677
//Fails due to HV-673
@Test(groups = Groups.FAILING_IN_RI)
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
Expand Down Expand Up @@ -1019,8 +1017,7 @@ public void testPropertyPathTraversingConstructorMapParameter() throws Exception
assertFalse( nodeIter.hasNext() );
}

//Fails on RI due to wrong return value name
@Test(groups = Groups.FAILING_IN_RI)
@Test
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
@SpecAssertion(section = "5.2", id = "n"),
Expand Down Expand Up @@ -1053,16 +1050,15 @@ public void testPropertyPathTraversingMethodReturnValue() throws Exception {
assertNode( nodeIter.next(), methodName, Kind.METHOD, false, null, null );

assertTrue( nodeIter.hasNext() );
assertNode( nodeIter.next(), "null", Kind.RETURN_VALUE, false, null, null );
assertNode( nodeIter.next(), null, Kind.RETURN_VALUE, false, null, null );

assertTrue( nodeIter.hasNext() );
assertNode( nodeIter.next(), "title", Kind.PROPERTY, false, null, null );

assertFalse( nodeIter.hasNext() );
}

//Fails on RI due to wrong return value name
@Test(groups = Groups.FAILING_IN_RI)
@Test
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
@SpecAssertion(section = "5.2", id = "n"),
Expand Down Expand Up @@ -1100,16 +1096,15 @@ public void testPropertyPathTraversingMethodListReturnValue() throws Exception {
assertNode( nodeIter.next(), methodName, Kind.METHOD, false, null, null );

assertTrue( nodeIter.hasNext() );
assertNode( nodeIter.next(), "null", Kind.RETURN_VALUE, false, null, null );
assertNode( nodeIter.next(), null, Kind.RETURN_VALUE, false, null, null );

assertTrue( nodeIter.hasNext() );
assertNode( nodeIter.next(), "title", Kind.PROPERTY, true, 1, null );

assertFalse( nodeIter.hasNext() );
}

//Fails on RI due to wrong return value name
@Test(groups = Groups.FAILING_IN_RI)
@Test
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
@SpecAssertion(section = "5.2", id = "n"),
Expand Down Expand Up @@ -1147,16 +1142,15 @@ public void testPropertyPathTraversingMethodArrayReturnValue() throws Exception
assertNode( nodeIter.next(), methodName, Kind.METHOD, false, null, null );

assertTrue( nodeIter.hasNext() );
assertNode( nodeIter.next(), "null", Kind.RETURN_VALUE, false, null, null );
assertNode( nodeIter.next(), null, Kind.RETURN_VALUE, false, null, null );

assertTrue( nodeIter.hasNext() );
assertNode( nodeIter.next(), "title", Kind.PROPERTY, true, 1, null );

assertFalse( nodeIter.hasNext() );
}

//fails on RI due to https://hibernate.onjira.com/browse/HV-646 and wrong return value node name
@Test(groups = Groups.FAILING_IN_RI)
@Test
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
@SpecAssertion(section = "5.2", id = "n"),
Expand Down Expand Up @@ -1190,16 +1184,15 @@ public void testPropertyPathTraversingMethodSetReturnValue() throws Exception {
assertNode( nodeIter.next(), methodName, Kind.METHOD, false, null, null );

assertTrue( nodeIter.hasNext() );
assertNode( nodeIter.next(), "null", Kind.RETURN_VALUE, false, null, null );
assertNode( nodeIter.next(), null, Kind.RETURN_VALUE, false, null, null );

assertTrue( nodeIter.hasNext() );
assertNode( nodeIter.next(), "title", Kind.PROPERTY, true, null, null );

assertFalse( nodeIter.hasNext() );
}

//fails on RI due to https://hibernate.onjira.com/browse/HV-677 and wrong return value node name
@Test(groups = Groups.FAILING_IN_RI)
@Test
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
@SpecAssertion(section = "5.2", id = "n"),
Expand Down Expand Up @@ -1237,16 +1230,15 @@ public void testPropertyPathTraversingMethodMapReturnValue() throws Exception {
assertNode( nodeIter.next(), methodName, Kind.METHOD, false, null, null );

assertTrue( nodeIter.hasNext() );
assertNode( nodeIter.next(), "null", Kind.RETURN_VALUE, false, null, null );
assertNode( nodeIter.next(), null, Kind.RETURN_VALUE, false, null, null );

assertTrue( nodeIter.hasNext() );
assertNode( nodeIter.next(), "title", Kind.PROPERTY, true, null, "NO_TITLE" );

assertFalse( nodeIter.hasNext() );
}

//Fails on RI due to wrong return value name
@Test(groups = Groups.FAILING_IN_RI)
@Test
@SpecAssertions({
@SpecAssertion(section = "5.2", id = "g"),
@SpecAssertion(section = "5.2", id = "n"),
Expand Down Expand Up @@ -1276,7 +1268,7 @@ public void testPropertyPathTraversingConstructorReturnValue() throws Exception
assertNode( nodeIter.next(), "MovieStudio", Kind.CONSTRUCTOR, false, null, null );

assertTrue( nodeIter.hasNext() );
assertNode( nodeIter.next(), "null", Kind.RETURN_VALUE, false, null, null );
assertNode( nodeIter.next(), null, Kind.RETURN_VALUE, false, null, null );

assertTrue( nodeIter.hasNext() );
assertNode( nodeIter.next(), "name", Kind.PROPERTY, false, null, null );
Expand Down

0 comments on commit b794285

Please sign in to comment.