Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do with categorical values with frequency 0? #128

Open
GuyBaele opened this issue Dec 11, 2017 · 1 comment
Open

What to do with categorical values with frequency 0? #128

GuyBaele opened this issue Dec 11, 2017 · 1 comment
Labels
Milestone

Comments

@GuyBaele
Copy link
Contributor

When loading a trace with categorical values into Tracer, it may contain several categories that were only visited during the burn-in. When the burn-in is subsequently omitted, some categories will have frequency 0. I've committed a small fix that avoids a NullPointerException for those categories, but the question remains: should we still plot that category (in the marginal density panel) but with frequency 0, or should we not plot those categories at all?

@rambaut
Copy link
Contributor

rambaut commented Jan 31, 2018

The other aspect of this is that a categorical value may not be visit even in burnin. Ideally all values should be shown even if zero frequency. Tracer has no way of knowing unvisited states exist. BEAST could define the set of categorical values in the log file's header (the initial lines prefixed with #).

@rambaut rambaut added this to the v1.7.1 milestone Jan 31, 2018
@rambaut rambaut modified the milestones: v1.7.1, v1.8 Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants