Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap and return standard library sql.DB for sqlmock support #179

Closed
nstratos opened this issue Mar 13, 2020 · 0 comments · Fixed by #178
Closed

Wrap and return standard library sql.DB for sqlmock support #179

nstratos opened this issue Mar 13, 2020 · 0 comments · Fixed by #178

Comments

@nstratos
Copy link

nstratos commented Mar 13, 2020 •
edited

Is your feature request related to a problem? Please describe

Some libraries like sqlmock initialise and return the standard library sql.DB which is not compatible with trace/sql.DB as they are different types.

Is this a bug? Please provide steps to reproduce, a failing test etc.

No.

Describe the solution

A function can wrap the standard library sql.DB which will allow support for libraries like sqlmock. This solution has been implemented in #178.

Additional context

Another function that can return the underlying sql.DB can be used for sql code that requires no tracing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

trace/sql: Wrap and return standard library sql.DB
1 participant
@nstratos