Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Install Breaks Incoming Webmentions #53

Closed
campegg opened this issue Jan 30, 2024 · 3 comments
Closed

Clean Install Breaks Incoming Webmentions #53

campegg opened this issue Jan 30, 2024 · 3 comments

Comments

@campegg
Copy link

campegg commented Jan 30, 2024

From v2.0.0 onwards, mf2py supports img alt text by default, which breaks incoming webmentions, since (I think!) the line hcard.avatar = urljoin(source_url, hcard.avatar) in mentions/tasks/incoming/remote.py expects source_url to be a string, but is being passed an object with value and alt instead of just the URL string. Trying to parse incoming webmentions throws TypeError: Cannot mix str and non-str arguments (see stack trace below).

The current requirements (mf2py>=1.1.2) will mean a clean install of django-wm will default to the latest version (currently 2.0.1). Downgrading to version 1.1.3 does solve the problem, however.

stack_trace.md

@beatonma
Copy link
Owner

beatonma commented Feb 2, 2024

Thank you - fix available in release 4.0.4.

@campegg
Copy link
Author

campegg commented Feb 2, 2024

Thank you, @beatonma—really appreciate the quick fix!

@beatonma
Copy link
Owner

beatonma commented Feb 2, 2024

(Not that quick - I came across and fixed tthis ~6 weeks ago while adding something for the next release but neglected to publish it :$)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants