Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2: add flag to hash token request parameters into state #86

Open
creativecoder opened this issue Oct 20, 2020 · 0 comments
Open

OAuth2: add flag to hash token request parameters into state #86

creativecoder opened this issue Oct 20, 2020 · 0 comments

Comments

@creativecoder
Copy link

creativecoder commented Oct 20, 2020

We're seeing more services implement strict url matching with the redirect URI during an OAuth 2.0 authentication flow.

Rather than doing this ad-hoc for each service, it would be more efficient to be able to opt in to this for any Oauth2 connection.

Idea from @pablinos

As using only the state parameter is the OAuth standard, I'm wondering if we should add the filter to Keyring_Service_OAuth2 if a flag is set ($this->pack_state = true in the constructor perhaps?), and then slowly convert the services.

@creativecoder creativecoder changed the title Oauth2: add flag to hash token request parameters into state OAuth2: add flag to hash token request parameters into state Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant