Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.2 Test Case Error #33

Closed
beaunus opened this issue Jul 24, 2017 · 6 comments
Closed

2.2 Test Case Error #33

beaunus opened this issue Jul 24, 2017 · 6 comments

Comments

@beaunus
Copy link
Owner

beaunus commented Jul 24, 2017

Ravishankar Joshi suggested that the results did not account for symmetric edges. It appears that our solution was based on a directed graph, rather than an undirected graph.

@beaunus
Copy link
Owner Author

beaunus commented Jul 24, 2017

Please confirm that the new test cases are correct and I will merge them to master.

https://github.com/beaunus/stanford-algs/tree/2.2-useUndirectedGraph/testCases/course2/assignment2Dijkstra

@ravibitsgoa
Copy link

I checked out with my solution for undirected graphs, and my answer is matching output files. Now, the test-cases are correct.

@beaunus
Copy link
Owner Author

beaunus commented Jul 25, 2017

Thank you. I have merged the new test cases to master.

@beaunus beaunus closed this as completed Jul 25, 2017
@Stevan0102
Copy link

Hi, it seems that your test cases are still in directed graph. E.g. https://github.com/beaunus/stanford-algs/blob/master/testCases/course2/assignment2Dijkstra/input_random_4_4.txt

@beaunus beaunus reopened this Sep 27, 2017
@beaunus
Copy link
Owner Author

beaunus commented Sep 27, 2017

Thank you, Stevan. I see.

I think that the solutions are correct if the client program interprets the input as an undirected graph. However, like Stevan0102 said, the test case files do not show edges going in both directions.

This week is a bit busy for me, including the weekend. I'll try my best to correct this as soon as possible. I can however, test any recommended alternatives rather quickly. I will keep you all informed as this progresses.

@beaunus
Copy link
Owner Author

beaunus commented Oct 11, 2017

Thank you for being patient.

I think that I have fixed the problem. Now, all input files have the edges in the adjacency list for both vertices.

Please let me know when you have confirmed the correctness of the test cases.

https://github.com/beaunus/stanford-algs/tree/2.2-directed_graph/testCases/course2/assignment2Dijkstra

Thank you.
Beau

@beaunus beaunus closed this as completed Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants