Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

space_after_anon_function doesn't work with anon async functions #1034

Closed
laggingreflex opened this issue Sep 25, 2016 · 5 comments
Closed

Comments

@laggingreflex
Copy link

laggingreflex commented Sep 25, 2016

Expected:

var c = async () {}

#608 related?

@bitwiseman
Copy link
Member

bitwiseman commented Sep 26, 2016

Kinda related, but not really. Functionally, this is an anonymous function so it should still be treated as such. I'd say this is more of a bug, whereas #608 is definitely a new feature (with a new setting to go with it. async es6, right?

@laggingreflex
Copy link
Author

I like ESLint's "space-before-function-paren" which covers all these (anon, named, anon async, named async) under one setting. Thoughts?

@bitwiseman
Copy link
Member

@laggingreflex - seems reasonable. We could use your help with this if you have the time.

@bitwiseman bitwiseman added this to the v1.7.x milestone Dec 26, 2016
@xueqingxiao
Copy link

xueqingxiao commented Apr 15, 2017

@bitwiseman any progress? Related: HookyQR/VSCodeBeautify#129

@MacKLess
Copy link
Collaborator

I ran this in v1.8.6 and it appears to force a space between "async" and the following parens as default. @laggingreflex and @xueqingxiao, please feel free to review this and let me know if you disagree. In the meantime, I'm going to mark this as resolved.

@bitwiseman bitwiseman modified the milestones: v1.8.x, v1.8.7 Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants