Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces added to handlebars with '=' #1460

Closed
MacKLess opened this issue Jul 25, 2018 · 1 comment
Closed

Spaces added to handlebars with '=' #1460

MacKLess opened this issue Jul 25, 2018 · 1 comment

Comments

@MacKLess
Copy link
Collaborator

Description

Based on Issue #660 in which the expected output should have looked like:

{{em-input label="Some Labe" property="amt" type="text" placeholder=""}}
{{em-input label="Type*" property="type" type="text" placeholder="(LTD)"}}
{{em-input label="Place*" property="place" type="text" placeholder=""}}

Obviously, the full support is not the point, but it shouldn't be adding the spaces.

Input

The code looked like this before beautification:

{{em-input label="Some Labe" property="amt" type="text" placeholder=""}} {{em-input label="Type*" property="type" type="text" placeholder="(LTD)"}} {{em-input label="Place*" property="place" type="text" placeholder=""}}

Current Output

The code actually looked like this after beautification:

{{em-input label= "Some Labe" property= "amt" type= "text" placeholder= ""}} {{em-input label= "Type*" property= "type" type= "text" placeholder= "(LTD)"}} {{em-input label= "Place*" property= "place" type= "text" placeholder= ""}}

Expected Output

The code should have looked like this after beautification:

/*This should be unchanged.*/
{{em-input label="Some Labe" property="amt" type="text" placeholder=""}} {{em-input label="Type*" property="type" type="text" placeholder="(LTD)"}} {{em-input label="Place*" property="place" type="text" placeholder=""}}

Environment

Browser User Agent:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36

Language Selected:
HTML

Settings

Example:

{
  "indent_size": "4",
  "indent_char": " ",
  "max_preserve_newlines": "5",
  "preserve_newlines": true,
  "keep_array_indentation": false,
  "break_chained_methods": false,
  "indent_scripts": "normal",
  "brace_style": "collapse",
  "space_before_conditional": true,
  "unescape_strings": false,
  "jslint_happy": false,
  "end_with_newline": false,
  "wrap_line_length": "0",
  "indent_inner_html": false,
  "comma_first": false,
  "e4x": false,
  "indent_handlebars": true
}
@bitwiseman
Copy link
Member

bitwiseman commented Jul 26, 2018

This occurs on the master branch currently. It doesn't repro in rc2, thankfully.
Great early catch.

@bitwiseman bitwiseman added this to the v1.8.x milestone Jul 26, 2018
@bitwiseman bitwiseman modified the milestones: v1.8.x, 1.8.0-rc3 Jul 31, 2018
@bitwiseman bitwiseman modified the milestones: 1.8.0-rc4, 1.8.0 Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants